Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract rustc stable hasher into it's own crate #755

Closed
1 of 3 tasks
Urgau opened this issue Jun 5, 2024 · 3 comments
Closed
1 of 3 tasks

Extract rustc stable hasher into it's own crate #755

Urgau opened this issue Jun 5, 2024 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@Urgau
Copy link
Member

Urgau commented Jun 5, 2024

Proposal

Extract the StableHasher (struct), StableHasherResult (trait) and SipHasher128 (struct) from rustc_data_structures into their own (new) crate rustc-stable-hash, similar to rustc-hash, so they can be used by other projects.

In particular, this would be useful for Cargo, which needs a cross-platform independent stable hasher for the trim-paths feature, rust-lang/cargo#13171 (comment).

The plan is to create a separate repo rustc-stable-hash (already done), create the infra1, import those parts1, publish the crate, use the new crate in rustc_data_structures.

Mentors or Reviewers

My-self, @Urgau.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Footnotes

  1. https://github.com/rust-lang/rustc-stable-hash/pull/1 2

@Urgau Urgau added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jun 5, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 5, 2024

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rustbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rustbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 5, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Jun 5, 2024

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jun 5, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 7, 2024
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jun 19, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 4, 2024
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 12, 2024
…erister

Use rustc-stable-hash in the compiler

Following rust-lang/compiler-team#755 and the release of the crate on crates.io, let's now use it in the compiler and remove the old implementation.

cc `@michaelwoerister`
r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants