Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin registrar change. #9790

Merged
merged 1 commit into from
Aug 15, 2021
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Aug 14, 2021

The plugin tests were broken due to a change in rust-lang/rust#85296 which removed the plugin_registrar attribute.

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2021
@nipunn1313
Copy link
Contributor

I took a look at the diff (and the referenced rust-lang/rust#85296) and it looks good. Thanks for fixing promptly!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 15, 2021

📌 Commit b34b767 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021
@bors
Copy link
Collaborator

bors commented Aug 15, 2021

⌛ Testing commit b34b767 with merge ddf9adb...

@bors
Copy link
Collaborator

bors commented Aug 15, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing ddf9adb to master...

@bors bors merged commit ddf9adb into rust-lang:master Aug 15, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2021
Update cargo

8 commits in b51439fd8b505d4800a257acfecf3c69f81e35cf..e96bdb0c3d0a418e7fcd7fbd69be08abf830b4bc
2021-08-09 18:40:05 +0000 to 2021-08-17 22:58:47 +0000
- Support using rustbot to ping the Windows group (rust-lang/cargo#9802)
- Show information about abnormal `fix` errors. (rust-lang/cargo#9799)
- Bump jobserver. (rust-lang/cargo#9798)
- Render build-std web links as hyperlinks (rust-lang/cargo#9795)
- Teach cargo to failfast on recursive/corecursive aliases (rust-lang/cargo#9791)
- Fix value-after-table error with profiles. (rust-lang/cargo#9789)
- Fix plugin registrar change. (rust-lang/cargo#9790)
- Ability to specify the output name for a bin target different from the crate name (rust-lang/cargo#9627)
ehuss pushed a commit to ehuss/cargo that referenced this pull request Aug 20, 2021
…hton

Fix plugin registrar change.

The plugin tests were broken due to a change in rust-lang/rust#85296 which removed the `plugin_registrar` attribute.
@ehuss ehuss mentioned this pull request Aug 20, 2021
bors added a commit that referenced this pull request Aug 20, 2021
[beta] Bump curl

Beta backport of #9809 to fix #9788

Also backport to appease CI:
* #9790 — Fix plugin registrar change.
* #9763 — Fix semver check for rust 1.54.0
@ehuss ehuss modified the milestones: 1.56.0, 1.55.0 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants