-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid setting RUSTC_BOOTSTRAP
from a build script on stable
#9181
Commits on Feb 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6c422a2 - Browse repository at this point
Copy the full SHA 6c422a2View commit details -
Downgrade error to a warning when
RUSTC_BOOTSTRAP
is set or this is…… the nightly channel
Configuration menu - View commit details
-
Copy full SHA for 418129d - Browse repository at this point
Copy the full SHA 418129dView commit details -
Suggest RUSTC_BOOTSTRAP=crate instead of RUSTC_BOOTSTRAP=1
This was the whole point of rust-lang/rust#77802. - Pass `pkg.name()` to `parse()`. This can't pass the `Package` directly because `PackageInner` is an `Rc` and therefore not thread-safe. Note that `pkg_name` was previously a *description* of the package, not the name passed with `--crate-name`.
Configuration menu - View commit details
-
Copy full SHA for e56417c - Browse repository at this point
Copy the full SHA e56417cView commit details -
Fix
masquerade_as_nightly_cargo
in work threadsPreviously, since `ENABLE_NIGHTLY_FEATURES` and `NIGHTLY_FEATURES_ENABLED` were thread locals, reading them in any other thread would always say nightly features were disabled. Now, they are tied to the `Context` itself, so it is both more clear how the variables are being set and fixes the behavior within work threads. Note that `Context` is not thread-safe, so this passes a boolean through to `BuildOutput::parse`.
Configuration menu - View commit details
-
Copy full SHA for 4b096be - Browse repository at this point
Copy the full SHA 4b096beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fc86e1 - Browse repository at this point
Copy the full SHA 8fc86e1View commit details -
Compute
enable_nightly_features
once instead of on each callThis avoids reparsing `channel()` over and over again. It also makes `maybe_enable_nightly_features` unnecessary and removes it.
Configuration menu - View commit details
-
Copy full SHA for 169b09c - Browse repository at this point
Copy the full SHA 169b09cView commit details -
Make
nightly_features_allowed
a field instead of a function`nightly_features_allowed()` is no longer doing any work, so it can be accessed directly. This also renames the `enable_nightly_features` field to `nightly_features_allowed`.
Configuration menu - View commit details
-
Copy full SHA for a572011 - Browse repository at this point
Copy the full SHA a572011View commit details -
Configuration menu - View commit details
-
Copy full SHA for eba5419 - Browse repository at this point
Copy the full SHA eba5419View commit details -
Fix test that assumed tests always were run on the stable channel
Note that this has to be set in the builder, before `config.configure()` gets run.
Configuration menu - View commit details
-
Copy full SHA for ecfdced - Browse repository at this point
Copy the full SHA ecfdcedView commit details -
Be less unix-centric in error messages
Co-authored-by: Eric Huss <eric@huss.org>
Configuration menu - View commit details
-
Copy full SHA for 09677c8 - Browse repository at this point
Copy the full SHA 09677c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a86ecf - Browse repository at this point
Copy the full SHA 3a86ecfView commit details
Commits on Feb 25, 2021
-
Remove unnecessary
config
argument toFeatures::add
The info was already present on `self`. Note that this uses a temporary variable to avoid a borrowck error from `slot`.
Configuration menu - View commit details
-
Copy full SHA for a6394bc - Browse repository at this point
Copy the full SHA a6394bcView commit details
Commits on Mar 3, 2021
-
Remove unhelpful link to Cargo book
It didn't have any information about RUSTC_BOOTSTRAP itself, only the general `rustc-env` feature.
Configuration menu - View commit details
-
Copy full SHA for 0b18165 - Browse repository at this point
Copy the full SHA 0b18165View commit details