Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid setting RUSTC_BOOTSTRAP from a build script on stable #9181

Merged
merged 13 commits into from
Mar 3, 2021

Commits on Feb 24, 2021

  1. Configuration menu
    Copy the full SHA
    6c422a2 View commit details
    Browse the repository at this point in the history
  2. Downgrade error to a warning when RUSTC_BOOTSTRAP is set or this is…

    … the nightly channel
    jyn514 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    418129d View commit details
    Browse the repository at this point in the history
  3. Suggest RUSTC_BOOTSTRAP=crate instead of RUSTC_BOOTSTRAP=1

    This was the whole point of rust-lang/rust#77802.
    
    - Pass `pkg.name()` to `parse()`. This can't pass the `Package` directly
      because `PackageInner` is an `Rc` and therefore not thread-safe. Note
      that `pkg_name` was previously a *description* of the package, not the
      name passed with `--crate-name`.
    jyn514 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e56417c View commit details
    Browse the repository at this point in the history
  4. Fix masquerade_as_nightly_cargo in work threads

    Previously, since `ENABLE_NIGHTLY_FEATURES` and
    `NIGHTLY_FEATURES_ENABLED` were thread locals, reading them in any other
    thread would always say nightly features were disabled. Now, they are
    tied to the `Context` itself, so it is both more clear how the variables
    are being set and fixes the behavior within work threads.
    
    Note that `Context` is not thread-safe, so this passes a boolean through
    to `BuildOutput::parse`.
    jyn514 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    4b096be View commit details
    Browse the repository at this point in the history
  5. Remove unused thread_locals

    jyn514 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    8fc86e1 View commit details
    Browse the repository at this point in the history
  6. Compute enable_nightly_features once instead of on each call

    This avoids reparsing `channel()` over and over again. It also makes
    `maybe_enable_nightly_features` unnecessary and removes it.
    jyn514 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    169b09c View commit details
    Browse the repository at this point in the history
  7. Make nightly_features_allowed a field instead of a function

    `nightly_features_allowed()` is no longer doing any work, so it can be
    accessed directly. This also renames the `enable_nightly_features` field
    to `nightly_features_allowed`.
    jyn514 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    a572011 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    eba5419 View commit details
    Browse the repository at this point in the history
  9. Fix test that assumed tests always were run on the stable channel

    Note that this has to be set in the builder, before
    `config.configure()` gets run.
    jyn514 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ecfdced View commit details
    Browse the repository at this point in the history
  10. Be less unix-centric in error messages

    Co-authored-by: Eric Huss <eric@huss.org>
    jyn514 and ehuss committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    09677c8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3a86ecf View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Remove unnecessary config argument to Features::add

    The info was already present on `self`.
    
    Note that this uses a temporary variable to avoid a borrowck error from
    `slot`.
    jyn514 committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    a6394bc View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Remove unhelpful link to Cargo book

    It didn't have any information about RUSTC_BOOTSTRAP itself, only the
    general `rustc-env` feature.
    jyn514 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    0b18165 View commit details
    Browse the repository at this point in the history