Fix permission issue with cargo vendor.
#9131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Proposed beta revert in #9132. |
ehuss
force-pushed
the
fix-vendor-permissions
branch
from
334149d
to
33f648a
Compare
|
@bors: r+ Thanks for investigating this! |
|
📌 Commit 33f648a has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 5, 2021
Update cargo 5 commits in e099df243bb2495b9b197f79c19f124032b1e778..34170fcd6e0947808a1ac63ac85ffc0da7dace2f 2021-02-01 16:24:34 +0000 to 2021-02-04 15:52:52 +0000 - Fix permission issue with `cargo vendor`. (rust-lang/cargo#9131) - Add split-debuginfo profile option (rust-lang/cargo#9112) - Add RegistryBuilder for tests, and update crates-io error handling. (rust-lang/cargo#9126) - Add some documentation for index and registry stuff. (rust-lang/cargo#9125) - Fix env/cfg set for `cargo test` and `cargo run`. (rust-lang/cargo#9122)
10 tasks
This was referenced May 7, 2021
danieldk
added a commit
to danieldk/nixpkgs
that referenced
this pull request
May 8, 2021
Rust 1.50.0 incorporated a Cargo change (rust-lang/cargo#8937) in which cargo vendor erroneously changed permissions of vendored crates. This was fixed in Rust 1.51.0 (rust-lang/cargo#9131). Unfortunately, this means that all cargoSha256/cargoHashes produced during the Rust 1.50.0 cycle are potentially broken. This change updates cargoSha256/cargoHash tree-wide. Fixes NixOS#121994.
jonringer
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
May 8, 2021
Rust 1.50.0 incorporated a Cargo change (rust-lang/cargo#8937) in which cargo vendor erroneously changed permissions of vendored crates. This was fixed in Rust 1.51.0 (rust-lang/cargo#9131). Unfortunately, this means that all cargoSha256/cargoHashes produced during the Rust 1.50.0 cycle are potentially broken. This change updates cargoSha256/cargoHash tree-wide. Fixes #121994.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there was an unintended regression in #8937 where the vendored output does not retain the original permissions.
Fixes #9127.