Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Add period to allowed feature name characters. #8943

Merged
merged 2 commits into from
Dec 5, 2020
Merged

[beta] Add period to allowed feature name characters. #8943

merged 2 commits into from
Dec 5, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 4, 2020

Beta backport of #8932.

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.49.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2020
@bors @ehuss
Auto merge of rust-lang#8930 - ehuss:fix-semver-msg, r=Eh2406
7bd820d 
Fix semver documentation tests.

GitHub just updated the VM image to include the latest stable rust (1.48), which included some minor changes to diagnostic outputs.  This updates the semver chapter tests which validates that the correct error is displayed for the 1.48 release.  These diagnostics were changed via rust-lang/rust#76524 and rust-lang/rust#73996.
@ehuss
Copy link
Contributor Author

ehuss commented Dec 4, 2020

Also added #8930 to get CI to pass.

@Eh2406
Copy link
Contributor

Eh2406 commented Dec 5, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 5, 2020

📌 Commit 7bd820d has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2020
@bors
Copy link
Collaborator

bors commented Dec 5, 2020

⌛ Testing commit 7bd820d with merge d00d64d...

@bors
Copy link
Collaborator

bors commented Dec 5, 2020

☀️ Test successful - checks-actions
Approved by: Eh2406
Pushing d00d64d to rust-1.49.0...

@bors bors merged commit d00d64d into rust-lang:rust-1.49.0 Dec 5, 2020
@ehuss ehuss mentioned this pull request Dec 5, 2020
Closed
@ehuss ehuss mentioned this pull request Jan 8, 2021
Merged
@ehuss ehuss added this to the 1.49.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Eh2406 Eh2406

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ehuss @rust-highfive @Eh2406 @bors