Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement external credential process. (RFC 2730) #8934

Merged
merged 8 commits into from
Dec 14, 2020
Merged

Implement external credential process. (RFC 2730) #8934

merged 8 commits into from
Dec 14, 2020

Commits on Dec 3, 2020

  1. Implement credential-process.

    @ehuss
    ehuss committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    cc6df1d View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2020

  1. Check for nul in Windows utf-16 wide-string.

    @ehuss
    ehuss committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    8ac04d1 View commit details
    Browse the repository at this point in the history

  2. Add docs on how cargo-credential finds the action argument.

    @ehuss
    ehuss committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    37e9c77 View commit details
    Browse the repository at this point in the history

  3. Add some credential manifest metadata and READMEs.

    @ehuss
    ehuss committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    69c5af8 View commit details
    Browse the repository at this point in the history

  4. Validate that the credential process only outputs a single line (token).

    @ehuss
    ehuss committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    bdbc8da View commit details
    Browse the repository at this point in the history

  5. Update credential-process tracking issue number.

    @ehuss
    ehuss committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    4b12011 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Change behavior when both token and credential-process is specified. 

    Change it so that if both are specified, it is an error just to be safer
for now.

If token is specified for a registry, ignore the global
credential-process.

I'm still uncertain if this is the best behavior, but I think we can
tweak it later if needed.
    @ehuss
    ehuss committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    395edf2 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Note that cargo-credential-gnome-secret won't be available precompiled. 

    The rust-lang/rust build infrastructure uses a version of Linux that is
too old to support building this.
    @ehuss
    ehuss committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    eabef56 View commit details
    Browse the repository at this point in the history