Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: we don't ignore version for git/path deps now #8900

Merged
merged 1 commit into from
Nov 25, 2020

Commits on Nov 25, 2020

  1. fix: we don't ignore version for git/path deps now

    Here's a sample invocation using Cargo 1.48 to prove this:
    
    ```
    $ cargo new test-cargo-version-path-constraints && cd test-cargo-version-path-constraints
         Created binary (application) `test-cargo-version-path-constraints` package
    
    $ echo 'windows-service = { version = "999", git = "https://github.com/NZXTCorp/windows-service-rs" }' >> Cargo.toml
    
    $ cargo build
        Updating git repository `https://github.com/NZXTCorp/windows-service-rs`
    error: failed to select a version for the requirement `windows-service = "^999"`
    candidate versions found which didn't match: 0.3.2
    location searched: Git repository https://github.com/NZXTCorp/windows-service-rs
    required by package `test-cargo-version-path-constraints v0.1.0 (C:\tools\msys64\home\erich\workspace\tmp\test-cargo-version-path-constraints)`
    ```
    ErichDonGubler committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    795dce1 View commit details
    Browse the repository at this point in the history