Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask out system core.autocrlf settings before resetting git repos #8523

Merged
merged 1 commit into from
Jul 23, 2020

Commits on Jul 21, 2020

  1. Mask out system core.autocrlf settings before resetting git repos

    This fixes an issue the gecko developers noticed when vendoring
    on windows. [0] If a user has `core.autocrlf=true` set
    (a reasonable default on windows), vendoring from a git source
    would cause all the newlines to be rewritten to include carriage
    returns, creating churn and platform-specific results.
    
    To fix this, we simply set the global cargo checkout's "local"
    core.autocrlf value before performing a `reset`. This masks out
    the system configuration without interfering with the user's
    own system/project settings.
    
    [0]:  https://bugzilla.mozilla.org/show_bug.cgi?id=1647582
    Gankra committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    4a1e710 View commit details
    Browse the repository at this point in the history