Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default values for readme if not specified #8277

Merged
merged 15 commits into from
Jun 9, 2020
Merged

Default values for readme if not specified #8277

merged 15 commits into from
Jun 9, 2020

Commits on May 17, 2020

  1. Set default for readme in Manifest if it's not specified. 

    If the readme field is not specified, assume a default of
"README.md" (temporarily). Further, if the readme field is set to
"false", then this defaulting behavior is suppressed.
    @tverghis
    tverghis committed May 17, 2020
    Configuration menu
    Copy the full SHA
    b23390b View commit details
    Browse the repository at this point in the history

  2. Use one of the default README file names if they exist

    @tverghis
    tverghis committed May 17, 2020
    Configuration menu
    Copy the full SHA
    3f46046 View commit details
    Browse the repository at this point in the history

  3. Use next() instead of nth(0)

    @tverghis
    tverghis committed May 17, 2020
    Configuration menu
    Copy the full SHA
    f42863c View commit details
    Browse the repository at this point in the history

  4. Refactor

    @tverghis
    tverghis committed May 17, 2020
    Configuration menu
    Copy the full SHA
    ffe5fbb View commit details
    Browse the repository at this point in the history

  5. Rustfmt

    @tverghis
    tverghis committed May 17, 2020
    Configuration menu
    Copy the full SHA
    0dfdba6 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. Add tests

    @tverghis
    tverghis committed May 25, 2020
    Configuration menu
    Copy the full SHA
    d1fe89e View commit details
    Browse the repository at this point in the history

  2. Rustfmt

    @tverghis
    tverghis committed May 25, 2020
    Configuration menu
    Copy the full SHA
    dcae5fc View commit details
    Browse the repository at this point in the history

  3. Update documentation for the readme field

    @tverghis
    tverghis committed May 25, 2020
    Configuration menu
    Copy the full SHA
    54b0432 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Simplify default_readme_from_package_root

    @tverghis
    tverghis committed May 28, 2020
    Configuration menu
    Copy the full SHA
    37836e6 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Change readme field in TomlProject to StringOrBool

    @tverghis
    tverghis committed May 29, 2020
    Configuration menu
    Copy the full SHA
    623c2d5 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @tverghis
    tverghis committed May 29, 2020
    Configuration menu
    Copy the full SHA
    05cfcb6 View commit details
    Browse the repository at this point in the history

  3. Update Manifest docs

    @tverghis
    tverghis committed May 29, 2020
    Configuration menu
    Copy the full SHA
    4d8e1ea View commit details
    Browse the repository at this point in the history

Commits on May 30, 2020

  1. Move constructor fn for manifest with readme to test file

    @tverghis
    tverghis committed May 30, 2020
    Configuration menu
    Copy the full SHA
    77c52c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Assume README.md if readme=true

    @tverghis
    tverghis committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    b0a3cc6 View commit details
    Browse the repository at this point in the history

  2. Create README file so tests pass

    @tverghis
    tverghis committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    58ee013 View commit details
    Browse the repository at this point in the history