Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build-plan): output invocations after running build scripts #7123

Closed
wants to merge 1 commit into from
Closed

feat(build-plan): output invocations after running build scripts #7123

wants to merge 1 commit into from

Commits on Jul 12, 2019

  1. feat(build-plan): output invocations after running build scripts

    Extend the `--build-plan` option with named value `STAGE` that indicates at
    which point in the build process to output the (remaining) invocations. The (up
    to now) only behavior is labeled as the `init` stage (compile nothing, add all
    invocations to the build plan) and a new stage is added, `post-build-scripts`,
    to compile and run custom build scripts (along with their dependencies) and
    generate the build plan with the invocations of the remaining units (that were
    actually going to be compiled and linked in the final binary/library).
    
    Add a new attribute to `Unit` (actually `UnitInner`), `to_be_compiled`, to
    signal (depending on the build plan selected, if any) which unit will be
    compiled and which added to the build plan (see its documentation for the full
    rationale of its inclusion in `Unit`). Replace the binary logic of local
    `build_plan: bool` variables, signaling if the `--build-plan` option is used,
    with the `to_be_compiled` attribute that contains a more fine-grained logic to
    decide which unit will be compiled (based on the build plan selected). This
    change is seen in the diff as (roughly) the replacement of `build_plan` (now
    deprecated) with the negated value (but same meaning) in `!to_be_compiled`.
    
    Add two tests for the new stage, and modify the basic test
    (`cargo_build_plan_simple`) to explicitly include the stage name `init` to test
    the new label (the rest of the build plan tests remain the same, to check
    backwards compatibility with the previous `--build-plan`-only use).
    schomatis committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    048b69e View commit details
    Browse the repository at this point in the history