ci: Run cargo fmt on all workspaces #7033
Conversation
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
We have tried this before and did not like it, but fmt is much more stable now. @alexcrichton thoughts? |
|
I'm generally in favor of this. I think rustfmt is stable enough it probably shouldn't be a problem. The main issue is the churn it causes on PRs, but I personally don't feel it is too bad. It would be nice if we had a bot that would leave a message when CI fails, particularly for this case, with nice instructions on what to do. We could also use a pre-existing bot like https://www.travisbuddy.com/. I suspect rust-log-analyzer isn't geared towards working on other repos, but maybe that could be used. I don't think that should gate the decision. For more context, here is the draft RFC for doing the same for rust-lang/rust which mentions adding bot support for pushing rustfmt changes: Centril/rfcs#21. I would think that is more trouble than it's worth. Issuing a command, waiting for it to finish, pulling the changes — sounds more complex than just running |
|
I'm willing to try this out now that rustfmt is more stable. I don't think it's a "perfect solution" but anything going more in depth in this is a huge amount more effort. I'd prefer though that the formatting check was a separate job in Travis rather than tacked onto an existing one |
|
Done. |
|
@bors: r+ |
|
📌 Commit b01f595 has been approved by |
bors
added
S-waiting-on-bors
ci: Run cargo fmt on all workspaces
|
☀️ Test successful - checks-travis, status-appveyor |
Update cargo 17 commits in 807429e1b6da4e2ec52488ef2f59e77068c31e1f..4c1fa54d10f58d69ac9ff55be68e1b1c25ecb816 2019-06-11 14:06:10 +0000 to 2019-06-24 11:24:18 +0000 - Fix typo in comment (rust-lang/cargo#7066) - travis: enforce formatting of subcrates as well (rust-lang/cargo#7063) - _cargo: Make function style consistent (rust-lang/cargo#7060) - Update some fix comments. (rust-lang/cargo#7061) - Stabilize default-run (rust-lang/cargo#7056) - Fix typo in comment (rust-lang/cargo#7054) - fix(fingerpring): do not touch intermediate artifacts (rust-lang/cargo#7050) - Resolver test/debug cleanup (rust-lang/cargo#7045) - Rename to_url → into_url (rust-lang/cargo#7048) - Remove needless lifetimes (rust-lang/cargo#7047) - Revert test directory cleaning change. (rust-lang/cargo#7042) - cargo book /reference/manifest: fix typo (rust-lang/cargo#7041) - Extract resolver tests to their own crate (rust-lang/cargo#7011) - ci: Do not install addons on rustfmt build jobs (rust-lang/cargo#7038) - Support absolute paths in dep-info files (rust-lang/cargo#7030) - ci: Run cargo fmt on all workspaces (rust-lang/cargo#7033) - Deprecated ONCE_INIT in favor of Once::new() (rust-lang/cargo#7031)
No description provided.