Refactor command definition #6894
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
k-nasa
commented
May 1, 2019
k-nasa
commented
- Removed call 'about'
- Changed the string "cargo" to use crate_name
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nrc
reviewed
May 1, 2019
src/bin/cargo/cli.rs
Outdated
| @@ -184,14 +184,13 @@ fn execute_subcommand(config: &mut Config, args: &ArgMatches<'_>) -> CliResult { | |||
| } | |||
|
|
|||
| fn cli() -> App { | |||
| App::new("cargo") | |||
| App::new(clap::crate_name!()) | |||
There was a problem hiding this comment.
Why make this change? ISTM this should be the name of the application, not the name of the crate?
k-nasa
force-pushed
the
refactor_cli_definition
branch
from
f577389
to
1577efa
Compare
|
@bors r+ Thanks! |
|
📌 Commit 1577efa has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 1, 2019
Refactor command definition - Removed call 'about' - Changed the string "cargo" to use crate_name
|
☀️ Test successful - checks-travis, status-appveyor |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
May 7, 2019
Update cargo 12 commits in beb8fcb5248dc2e6aa488af9613216d5ccb31c6a..759b6161a328db1d4863139e90875308ecd25a75 2019-04-30 23:58:00 +0000 to 2019-05-06 20:47:49 +0000 - Small things (rust-lang/cargo#6910) - Fix skipping over invalid registry packages (rust-lang/cargo#6912) - Fixes rust-lang/cargo#6874 (rust-lang/cargo#6905) - doc: Format examples of version to ease reading (rust-lang/cargo#6907) - fix more typos (codespell) (rust-lang/cargo#6903) - Parse less JSON on null builds (rust-lang/cargo#6880) - chore: Update opener to 0.4 (rust-lang/cargo#6902) - Update documentation for auto-discovery. (rust-lang/cargo#6898) - Update some doc links. (rust-lang/cargo#6897) - Default Cargo.toml template provide help for completing the metadata (rust-lang/cargo#6881) - Run 'cargo fmt --all' (rust-lang/cargo#6896) - Refactor command definition (rust-lang/cargo#6894)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.