Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BackPort] Conservative updates #6655

Merged
merged 10 commits into from
Feb 12, 2019
Merged

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Feb 12, 2019

This is a back port of #6611 as discussed in #6609

Eh2406 and others added 9 commits February 12, 2019 15:08
If we're updating a crate then its previous version in the lock file is
no longer whitelisted. We may want to perhaps change this in the future!
When sources already exist in a `PackageRegistry` and the whitelist is
updated in the package registry, be sure to update all the existing
sources to ensure that everyone gets the same view of the intended whitelist.
@rust-highfive
Copy link

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.33.0. Please double check that you specified the right target!

@ehuss
Copy link
Contributor

ehuss commented Feb 12, 2019

Looks like #6649 will be needed to get this to pass. I'll post it in a few minutes.

@Eh2406
Copy link
Contributor Author

Eh2406 commented Feb 12, 2019

Or you can push to this branch whatever is easier.

The unused_imports warning is going to emit fixable suggestions in the
near future, but that means parts of the cargo's test suite will break.
This commit switches the tests to use the deprecated warning, which
*shouldn't* be fixable at all.
@ehuss
Copy link
Contributor

ehuss commented Feb 12, 2019

@bors r+

I'm planning to update beta (on rust-lang/rust) towards the end of the week.

@bors
Copy link
Collaborator

bors commented Feb 12, 2019

📌 Commit 63412be has been approved by ehuss

@bors
Copy link
Collaborator

bors commented Feb 12, 2019

⌛ Testing commit 63412be with merge f099fe9...

bors added a commit that referenced this pull request Feb 12, 2019
[BackPort] Conservative updates

This is a back port of #6611 as discussed in #6609
@bors
Copy link
Collaborator

bors commented Feb 12, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: ehuss
Pushing f099fe9 to rust-1.33.0...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants