Add support for a default registry for cargo commands #6135
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
src/bin/cargo/command_prelude.rs
Outdated
| @@ -359,9 +360,22 @@ pub trait ArgMatchesExt { | |||
| requires -Zunstable-options to use." | |||
| )); | |||
| } | |||
| Ok(Some(registry.to_string())) | |||
|
|
|||
| if registry == "crates.io" { | |||
There was a problem hiding this comment.
I think this may be one of the few places that we accept this string, right? If so, could the special casing not be done here and perhaps later in a more centralized location?
There was a problem hiding this comment.
Small nit - crates-io is used rather than crates.io in [patch] blocks so it might make sense to use the same here for consistency.
There was a problem hiding this comment.
I think this may be one of the few places that we accept this string, right? If so, could the special casing not be done here and perhaps later in a more centralized location?
I have made the string a constant (and updated other uses of it), so it is now just doing a string comparison, I did consider moving the logic into source_id, but we don't always need the source (for example in publish), so I have left it where it was. Is that ok?
…h when registry is not specified
|
@bors: r+ |
|
📌 Commit 1fd3f1b has been approved by |
Add support for a default registry for cargo commands This adds two things: - --registry support for new and init - adds default registry configuration to cargo The main reason for these changes is to reduce the risk of closed-source software ending up accidentally on crates.io. This fixes #6123.
|
☀️ Test successful - status-appveyor, status-travis |
This adds two things:
The main reason for these changes is to reduce the risk of closed-source software ending up accidentally on crates.io.
This fixes #6123.