Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustfmt instructions in CONTRIBUTING.md #5880

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Aug 9, 2018

rustfmt's --skip-children is now behind --unstable-features
(rust-lang/rustfmt#2796) which only works on nightly rustfmt, so
change the install instructions too.

rustfmt's --skip-children is now behind --unstable-features
(rust-lang/rustfmt#2796) which only works on nightly rustfmt, so
change the install instructions too.
@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 10, 2018

📌 Commit ad5610f has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Aug 10, 2018

⌛ Testing commit ad5610f with merge 1778152...

bors added a commit that referenced this pull request Aug 10, 2018
Fix rustfmt instructions in CONTRIBUTING.md

rustfmt's --skip-children is now behind --unstable-features
(rust-lang/rustfmt#2796) which only works on nightly rustfmt, so
change the install instructions too.
@bors
Copy link
Collaborator

bors commented Aug 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1778152 to master...

@bors bors merged commit ad5610f into rust-lang:master Aug 10, 2018
@dwijnand dwijnand deleted the fix-rustfmt-instructions branch August 10, 2018 06:19
bors added a commit to rust-lang/rust that referenced this pull request Aug 15, 2018
Update cargo

- Update transitioning url (rust-lang/cargo#5889)
- Resolve some clippy lint warnings (rust-lang/cargo#5884)
- Don't kill child processes on normal exit on Windows (rust-lang/cargo#5887)
- fix a bunch of clippy warnings (rust-lang/cargo#5876)
- Add support for rustc's --error-format short (rust-lang/cargo#5879)
- Support JSON with rustdoc. (rust-lang/cargo#5878)
- Fix rustfmt instructions in CONTRIBUTING.md (rust-lang/cargo#5880)
- Allow `cargo run` in workspaces. (rust-lang/cargo#5877)
- Change target filters in workspaces. (rust-lang/cargo#5873)
- Improve verbose console and log for finding git repo in package check (rust-lang/cargo#5858)
- Meta rename (rust-lang/cargo#5871)
- fetch: skip target tests when cross_compile is disabled (rust-lang/cargo#5870)
- Fully capture rustc and rustdoc output when -Zcompile-progress is passed (rust-lang/cargo#5862)
- Fix test --example docs. (rust-lang/cargo#5867)
- Add a feature to build a vendored OpenSSL (rust-lang/cargo#5865)
@ehuss ehuss added this to the 1.30.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants