Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less aggressively poison sources on builds #5288

Merged
merged 1 commit into from
Apr 4, 2018

Commits on Apr 3, 2018

  1. Less aggressively poison sources on builds

    Discovered in rust-lang#5257 the changes in rust-lang#5215 were slightly too aggressively
    poisoning sources to require updates, thinking that a manifest changed when it
    actually hadn't.
    
    Non-workspace-member path dependencies with optional/dev-dependencies
    don't show up in the lock file, so the previous logic would recognize this and
    think that the dependency missing from the lock file was just added and would
    require a registry update.
    
    The fix in this commit effectively just skips all of these dependencies in
    non-workspace members. This means that this will be slightly buggy if an
    optional dependency that's activated is added, but that's hopefully something we
    can tackle later.
    
    Closes rust-lang#5257
    alexcrichton committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    0790db9 View commit details
    Browse the repository at this point in the history