-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stabilize cargo update --precise <yanked>
#13974
Conversation
@rfcbot fcp merge Although we discussed this earlier today as a team, it's better to have a record here. |
Team member @weihanglo has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Thanks! @bors r+ |
feat: stabilize `cargo update --precise <yanked>` ### What does this PR try to resolve? Stabilize `cargo update --precise <yanked>`. The cargo team has discussed the stabilization in the meeting today. The interface of this is quite small and not as controversial as `--precise <pre-release>`, since there is no version requirement operators involved. We'd like to move forward and stabilize this part. Note that `--precise <yanked>` allows using yanked version only for the specified package, We leave the cascading allowing yanked versions (e.g. <#4225 (comment)>) as a future extension. ### How should we test and review this PR? Check if any adjustment needed for warnings and CLI help text. ### Additional information cc <#4225>.
💔 Test failed - checks-actions |
Network error. @bors retry |
feat: stabilize `cargo update --precise <yanked>` ### What does this PR try to resolve? Stabilize `cargo update --precise <yanked>`. The cargo team has discussed the stabilization in the meeting today. The interface of this is quite small and not as controversial as `--precise <pre-release>`, since there is no version requirement operators involved. We'd like to move forward and stabilize this part. Note that `--precise <yanked>` allows using yanked version only for the specified package, We leave the cascading allowing yanked versions (e.g. <#4225 (comment)>) as a future extension. ### How should we test and review this PR? Check if any adjustment needed for warnings and CLI help text. ### Additional information cc <#4225>.
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
Update cargo 9 commits in 431db31d0dbeda320caf8ef8535ea48eb3093407..7a6fad0984d28c8330974636972aa296b67c4513 2024-05-28 18:17:31 +0000 to 2024-05-31 22:26:03 +0000 - fix(config): Ensure `--config net.git-fetch-with-cli=true` is respected (rust-lang/cargo#13992) - Fix libcurl proxy documentation link (rust-lang/cargo#13990) - fix(new): Dont say were adding to a workspace when a regular package is in root (rust-lang/cargo#13987) - fix: adjust custom err from cert-check due to libgit2 1.8 change (rust-lang/cargo#13970) - fix(toml): Ensure targets are in a deterministic order (rust-lang/cargo#13989) - doc(cargo-package): explain no guarantee of vcs provenance (rust-lang/cargo#13984) - chore: fix some comments (rust-lang/cargo#13982) - feat: stabilize `cargo update --precise <yanked>` (rust-lang/cargo#13974) - Update openssl-src to 111.28.2+1.1.1w (rust-lang/cargo#13976) r? ghost
What does this PR try to resolve?
Stabilize
cargo update --precise <yanked>
.The cargo team has discussed the stabilization in the meeting today.
The interface of this is quite small and not as controversial as
--precise <pre-release>
,since there is no version requirement operators involved.
We'd like to move forward and stabilize this part.
Note that
--precise <yanked>
allows using yanked version only for the specified package,We leave the cascading allowing yanked versions (e.g. #4225 (comment)) as a future extension.
How should we test and review this PR?
Check if any adjustment needed for warnings and CLI help text.
Additional information
cc #4225.