Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shell): Use alternate to close links #13562

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

epage
Copy link
Contributor

@epage epage commented Mar 8, 2024

What does this PR try to resolve?

Simplifies the code for includign hyperlinks, especially the fact that this allows for including the variable in the format string.

How should we test and review this PR?

Hand tested each case as we don't have SVG support for hyperlinks and we don't have SVG tests for these cases

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-console-output Area: Terminal output, colors, progress bar, etc. A-timings Area: timings Command-doc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2024
@weihanglo
Copy link
Member

Tested. Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 8, 2024

📌 Commit af9f134 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2024
@bors
Copy link
Collaborator

bors commented Mar 8, 2024

⌛ Testing commit af9f134 with merge 36cf66a...

@bors
Copy link
Collaborator

bors commented Mar 8, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 36cf66a to master...

@bors bors merged commit 36cf66a into rust-lang:master Mar 8, 2024
21 checks passed
@epage epage deleted the hyperlink branch March 8, 2024 19:52
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2024
Update cargo

9 commits in a4c63fe5388beaa09e5f91196c86addab0a03580..7065f0ef4aa267a7455e1c478b5ccacb7baea59c
2024-03-06 22:15:17 +0000 to 2024-03-12 13:25:15 +0000
- chore: remove repetitive word (rust-lang/cargo#13575)
- refactor(lockfile): Make diffing/printing more reusable (rust-lang/cargo#13564)
- test: Add tests for using worktrees and sparse checkouts (rust-lang/cargo#13567)
- util/network/http: Use `cargo/1.2.3` user-agent header (rust-lang/cargo#13548)
- fix: Consistently compare MSRVs (rust-lang/cargo#13537)
- refactor(shell): Use alternate to close links (rust-lang/cargo#13562)
- fix(doc): Collapse down Generated statuses without --verbose (rust-lang/cargo#13557)
- doc: Add doc for -Zpublic-dependency (rust-lang/cargo#13556)
- docs: add link to the exported_private_dependencies lint (rust-lang/cargo#13547)

r? ghost
@rustbot rustbot added this to the 1.78.0 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-execution Area: anything dealing with executing the compiler A-console-output Area: Terminal output, colors, progress bar, etc. A-timings Area: timings Command-doc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants