Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update auto labels #13244

Merged
merged 3 commits into from
Jan 3, 2024
Merged

chore: update auto labels #13244

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77a5f24
chore: label `Command-fix` for diagnostic-server changes
weihanglo Jan 2, 2024
c1461b5
chore: label `A-manifest` for part of cargo-util-schemas
weihanglo Jan 2, 2024
872f4df
chore: remove `A-errors` auto label
weihanglo Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions triagebot.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,6 @@ trigger_files = [
"src/cargo/util/config/environment.rs",
]

[autolabel."A-errors"]
trigger_files = ["src/cargo/util/diagnostic_server.rs"]
Comment on lines -123 to -124
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it deleted the trigger, was that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like that diagnostic_server.rs should belong to Command-fix, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was not clear. I was confused that this is adding this empty table:

[autolabel."A-diagnostics"]

for A-diagnostics without any keys. If that table is not needed, I'm not clear why it is being added (I wasn't sure if there was a trigger_files intended to be added here).

Feel free to r=ehuss either way.


[autolabel."A-features2"]
trigger_files = ["src/cargo/core/resolver/features.rs"]

Expand Down Expand Up @@ -174,6 +171,7 @@ trigger_files = ["src/cargo/core/compiler/lto.rs"]

[autolabel."A-manifest"]
trigger_files = [
"crates/cargo-util-schemas/src/manifest.rs",
"src/cargo/core/manifest.rs",
"src/cargo/util/toml/mod.rs",
"src/cargo/util/toml_mut/",
Expand Down Expand Up @@ -259,10 +257,11 @@ trigger_files = ["src/bin/cargo/commands/fetch.rs", "src/cargo/ops/cargo_fetch.r

[autolabel."Command-fix"]
trigger_files = [
"crates/rustfix/",
"src/bin/cargo/commands/fix.rs",
"src/cargo/ops/fix.rs",
"src/cargo/util/diagnostic_server.rs",
"src/cargo/util/lockserver.rs",
"crates/rustfix/",
]

[autolabel."Command-generate-lockfile"]
Expand Down