Don't try to compile cargo-credential-gnome-secret on non-Linux platforms. #12321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-registry-authentication
weihanglo
approved these changes
Jun 29, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
|
What the merge has yet been triggered? @bors r- |
bors
added
S-waiting-on-author
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 1, 2023
Update cargo 6 commits in 03bc66b55c290324bd46eb22e369c8fae1908f91..5b377cece0e0dd0af686cf53ce4637d5d85c2a10 2023-06-23 23:27:46 +0000 to 2023-06-30 00:01:00 +0000 - Add READMEs for the credential helpers. (rust-lang/cargo#12322) - Add some more documentation for Source download functions. (rust-lang/cargo#12319) - Don't try to compile cargo-credential-gnome-secret on non-Linux platforms. (rust-lang/cargo#12321) - refactor: use macro to remove duplication of workspace inheritable fields getters (rust-lang/cargo#12317) - doc: should be `.cargo-ok` (rust-lang/cargo#12318) - refactor(registry): extract and rearrange items to their own modules (rust-lang/cargo#12290) r? `@ghost`
bors
added a commit
that referenced
this pull request
Jul 11, 2023
chore(ci): Automatically test new packages by using `--workspace` ### What does this PR try to resolve? This is a part of #11987 that was unblocked by #12321 and #11993 ### How should we test and review this PR? Relying on CI to verify this I'd prefer to move the `cargo test --workspace` step earlier but we run out of disk space if we do (we currently only have 661 MB of headroom of windows-gnu) See the individual commits for smaller chunks and explanations for why changes were made.
bors
added a commit
that referenced
this pull request
Jul 11, 2023
chore(ci): Automatically test new packages by using `--workspace` ### What does this PR try to resolve? This is a part of #11987 that was unblocked by #12321 and #11993 ### How should we test and review this PR? Relying on CI to verify this I'd prefer to move the `cargo test --workspace` step earlier but we run out of disk space if we do (we currently only have 661 MB of headroom of windows-gnu) See the individual commits for smaller chunks and explanations for why changes were made.
bors
added a commit
that referenced
this pull request
Jul 11, 2023
chore(ci): Automatically test new packages by using `--workspace` ### What does this PR try to resolve? This is a part of #11987 that was unblocked by #12321 and #11993 ### How should we test and review this PR? Relying on CI to verify this I'd prefer to move the `cargo test --workspace` step earlier but we run out of disk space if we do (we currently only have 661 MB of headroom of windows-gnu) See the individual commits for smaller chunks and explanations for why changes were made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup on #11993 to put the same treatment for
cargo-credential-gnome-secretso that it builds on non-Linux platforms, substituting the "unsupported" implementation in that case.This will still fail on Linux platforms that don't have libsecret-1-dev installed. I'm not sure how to best treat that, since we do want an error to be generated if the user tries to run
cargo install cargo-credential-gnome-secret, and they don't have libsecret installed.