chore: move build-man workflow away from shell #12048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-cli-help
epage
reviewed
Apr 28, 2023
crates/mdman/src/bin/build-man.rs
Outdated
| @@ -0,0 +1,110 @@ | |||
| use std::fs; | |||
There was a problem hiding this comment.
Is there a reason we put this in mdman?
I figured us having specific top-level xtask- packages would help raise visibility on what xtasks exist
There was a problem hiding this comment.
Good point. I have no idea what I was doing.
BTW, do you feel like we should probably have only crates meant to be published stay in crates/, and move others elsewhere?
There was a problem hiding this comment.
BTW, do you feel like we should probably have only crates meant to be published stay in crates/, and move others elsewhere?
I can go either way. Some of the crates are a given that they won't be published while some might transition to being published (cargo-test-support as an example of one that could switch). Its a little churn to move stuff but git should mostly handle it.
epage
reviewed
Apr 28, 2023
epage
reviewed
Apr 28, 2023
crates/mdman/src/bin/build-man.rs
Outdated
Comment on lines
23
to
36
| cmd.args(["run", "--package", std::env!("CARGO_PKG_NAME"), "--"]) | ||
| .args([ | ||
| "-t", | ||
| format, | ||
| "-o", | ||
| &format!("{mdman_root}/doc/out"), | ||
| &format!("{mdman_root}/doc/mdman.md"), | ||
| ]); | ||
|
|
||
| let status = cmd.status()?; | ||
| if !status.success() { | ||
| eprintln!("failed to run command `{cmd:?}`"); | ||
| process::exit(status.code().unwrap_or(1)); | ||
| } |
There was a problem hiding this comment.
Should we consider using xshell?
There was a problem hiding this comment.
Have no strong opinion at this moment. I can look back when implementing version bump check. The crate does look nice tho.
Turn `src/doc/build-man.sh` into a Cargo binary target. So is `crates/mdman/build-man.sh`.
rustbot
added
the
A-infrastructure
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2023
Update cargo 16 commits in 9e586fbd8b931494067144623b76c37d213b1ab6..ac84010322a31f4a581dafe26258aa4ac8dea9cd 2023-04-25 22:09:11 +0000 to 2023-05-02 13:41:16 +0000 - docs(registry): Further specify owner-remove response (rust-lang/cargo#12056) (rust-lang/cargo#12068) - Remove repeated definite articles (rust-lang/cargo#12067) - Document that adding `#[non_exhaustive]` on existing items is breaking. (rust-lang/cargo#10877) - docs(commands): add missed preposition (rust-lang/cargo#12073) - Fix warning with unused mut (rust-lang/cargo#12065) - chore: move build-man workflow away from shell (rust-lang/cargo#12048) - feat: Add `-Zmsrv-policy` feature flag (rust-lang/cargo#12043) - chore: new xtask to check stale paths in autolabel defintions (rust-lang/cargo#12051) - cargo-tree: Handle -e no-proc-macro when building the graph (rust-lang/cargo#12044) - chore: update trigger_files in autolabel (rust-lang/cargo#12052) - fix broken markdown in docs (rust-lang/cargo#12049) - home: fix & enhance documentation (rust-lang/cargo#12047) - chore: Mark unpublished crates as such (rust-lang/cargo#12045) - Include rust-version in publish request (rust-lang/cargo#12041) - chore(xtask): Add `cargo xtask unpublished` (rust-lang/cargo#12039) - docs(ref): Specify 'rust_version' in Index format (rust-lang/cargo#12040) r? `@ghost`
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
May 3, 2023
Update cargo 16 commits in 9e586fbd8b931494067144623b76c37d213b1ab6..ac84010322a31f4a581dafe26258aa4ac8dea9cd 2023-04-25 22:09:11 +0000 to 2023-05-02 13:41:16 +0000 - docs(registry): Further specify owner-remove response (rust-lang/cargo#12056) (rust-lang/cargo#12068) - Remove repeated definite articles (rust-lang/cargo#12067) - Document that adding `#[non_exhaustive]` on existing items is breaking. (rust-lang/cargo#10877) - docs(commands): add missed preposition (rust-lang/cargo#12073) - Fix warning with unused mut (rust-lang/cargo#12065) - chore: move build-man workflow away from shell (rust-lang/cargo#12048) - feat: Add `-Zmsrv-policy` feature flag (rust-lang/cargo#12043) - chore: new xtask to check stale paths in autolabel defintions (rust-lang/cargo#12051) - cargo-tree: Handle -e no-proc-macro when building the graph (rust-lang/cargo#12044) - chore: update trigger_files in autolabel (rust-lang/cargo#12052) - fix broken markdown in docs (rust-lang/cargo#12049) - home: fix & enhance documentation (rust-lang/cargo#12047) - chore: Mark unpublished crates as such (rust-lang/cargo#12045) - Include rust-version in publish request (rust-lang/cargo#12041) - chore(xtask): Add `cargo xtask unpublished` (rust-lang/cargo#12039) - docs(ref): Specify 'rust_version' in Index format (rust-lang/cargo#12040) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Turn
src/doc/build-man.shinto a Cargo binary target.So is
crates/mdman/build-man.sh.How should we test and review this PR?
Run
cargo build-manAdditional information
We should leverage workspace inheritance for dependencies.
Fixes #11717