Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BETA-1.65] Fix deadlock when build scripts are waiting for input on stdin #11257

Merged
merged 2 commits into from
Oct 20, 2022
Merged

[BETA-1.65] Fix deadlock when build scripts are waiting for input on stdin #11257

merged 2 commits into from
Oct 20, 2022

Conversation

arlosi
Copy link
Contributor

@arlosi arlosi commented Oct 19, 2022

Beta backport of #11205. Cherry picked d51ed05.

r? @ehuss

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.65.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2022
@ehuss
Copy link
Contributor

ehuss commented Oct 19, 2022

Can you also pull in #11221 to get CI passing again? Thanks!

weihanglo
weihanglo approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 20, 2022

📌 Commit b005e9b has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2022
@bors
Copy link
Collaborator

bors commented Oct 20, 2022

⌛ Testing commit b005e9b with merge 4bc8f24...

@bors
Copy link
Collaborator

bors commented Oct 20, 2022

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 4bc8f24 to rust-1.65.0...

@bors bors merged commit 4bc8f24 into rust-lang:rust-1.65.0 Oct 20, 2022
weihanglo added a commit to weihanglo/rust that referenced this pull request Oct 20, 2022
@weihanglo
[beta] Update cargo
74f6f80 
1 commits in 082503982ea0fb7a8fd72210427d43a2e2128a63..4bc8f24d3e899462e43621aab981f6383a370365
2022-09-13 17:49:38 +0000 to 2022-10-20 06:00:42 +0000

- [BETA-1.65] Fix deadlock when build scripts are waiting for input on stdin (rust-lang/cargo#11257)
@weihanglo weihanglo mentioned this pull request Oct 20, 2022
Closed
cuviper pushed a commit to cuviper/rust that referenced this pull request Oct 20, 2022
@weihanglo @cuviper
[beta] Update cargo
b1fb60e 
1 commits in 082503982ea0fb7a8fd72210427d43a2e2128a63..4bc8f24d3e899462e43621aab981f6383a370365
2022-09-13 17:49:38 +0000 to 2022-10-20 06:00:42 +0000

- [BETA-1.65] Fix deadlock when build scripts are waiting for input on stdin (rust-lang/cargo#11257)
@ehuss ehuss added this to the 1.65.0 milestone Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
5 participants
@arlosi @rust-highfive @ehuss @weihanglo @bors