Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend pkgid syntax with @ support #10582

Merged
merged 2 commits into from
May 6, 2022
Merged

Extend pkgid syntax with @ support #10582

merged 2 commits into from
May 6, 2022

Commits on Apr 19, 2022

  1. Extend pkgid syntax with @ support

    In addition to `foo:1.2.3`, we now support `foo@1.2.3` for pkgids.  We
    are also making it the default way of rendering pkgid's for the user.
    
    With cargo-add in rust-lang#10472, we've decided to only use `@` in it and to add
    it as an alternative to `:` in the rest of cargo.  `cargo-add`
    originally used `@`.  When preparing it for merge, I switched to `:` to
    be consistent with pkgids. When discussing this, it was felt `@` has
    precedence in too many tools to switch to `:` but that we should instead
    switch pkgid's to use `@`, in a backwards compatible way.
    
    See also https://internals.rust-lang.org/t/feedback-on-cargo-add-before-its-merged/16024/26?u=epage
    epage committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    cdec383 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Document the use of @ in PKGID Specs

    Since the `cargo pkgid` docs were so brief, I figured I'd focus on the
    expected common case and only cover `@` while the reference mentions
    both in the grammar.
    epage committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    709f1be View commit details
    Browse the repository at this point in the history