Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry command invocation with argfile #10546

Merged
merged 16 commits into from
Apr 11, 2022
Merged

Retry command invocation with argfile #10546

merged 16 commits into from
Apr 11, 2022

Commits on Apr 8, 2022

  1. Separate command wrappers from command arguments

    @weihanglo
    weihanglo committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    c9d443a View commit details
    Browse the repository at this point in the history

  2. Retry with argfile if hitting "command line too big" error 

    - Add `ProcessBuilder::output` and ProcessBuilder::status`, which are
  unopinionated version of `exec_*` (won't error out when exitcode > 0)
- Add `ProcessBuilder::retry_with_argfile` to enable trying with argfile
  when hitting the "command line too big" error.
    @weihanglo
    weihanglo committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    b788e52 View commit details
    Browse the repository at this point in the history

  3. Bump cargo-util to 0.1.3

    @weihanglo
    weihanglo committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    4f6a2ec View commit details
    Browse the repository at this point in the history

  4. Avoid calling build_command in fn cached_output

    @weihanglo
    weihanglo committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    734569c View commit details
    Browse the repository at this point in the history

  5. Avoid calling build_command in cargo fix

    @weihanglo
    weihanglo committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    c832a7a View commit details
    Browse the repository at this point in the history

  6. Retry with argfile for rustc/rustdoc

    @weihanglo
    weihanglo committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    832274d View commit details
    Browse the repository at this point in the history

  7. Retry with argfile for cargo in rustc fix-proxy-mode

    @weihanglo
    weihanglo committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    fc05277 View commit details
    Browse the repository at this point in the history

  8. Use CargoResult pervasively

    @weihanglo
    weihanglo committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    beaaefd View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. State that arg in argfile must not contain newlines

    @weihanglo
    weihanglo committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    877c0ad View commit details
    Browse the repository at this point in the history

  2. Avoid collect args from `env::args in proxy mode 

    cargo in fix-proxy-mode might read `@path` argfile as what rustc does.
Therefore, we should collect info from `ProcessBuilder::get_args()`.
    @weihanglo
    weihanglo committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    8e0e68e View commit details
    Browse the repository at this point in the history

  3. Ensure that temporary argfile lives longer them command execution

    @weihanglo
    weihanglo committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    9155c00 View commit details
    Browse the repository at this point in the history

  4. Ensure non-UTF8 compatibility of argfile arg

    @weihanglo
    weihanglo committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    3f749f6 View commit details
    Browse the repository at this point in the history

  5. Debug assertion for rustc argfile invocations

    @weihanglo
    weihanglo committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    5e8827f View commit details
    Browse the repository at this point in the history

  6. Close tempfile explicitly after the command to exist

    @weihanglo
    weihanglo committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    7146111 View commit details
    Browse the repository at this point in the history

  7. test: make tests compatible when force using argfile

    @weihanglo
    weihanglo committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    d813739 View commit details
    Browse the repository at this point in the history

  8. CI: force using argfile to test againg cargo fix

    @weihanglo
    weihanglo committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    275b0c6 View commit details
    Browse the repository at this point in the history