Compute non custom build and non transitive deps for doc #10341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
|
r? @ehuss The robot doesn't seem to be working. |
ehuss
reviewed
Feb 1, 2022
Make sense. Addressed! |
ehuss
reviewed
Feb 3, 2022
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Rustin170506
force-pushed
the
rustin-patch-doc-deps
branch
from
1da91f1
to
bd45ac8
Compare
|
Thanks! There was once a reason why these two different code paths had different filters, but I cannot recall from the dusty recesses of my mind why that was. I've tried to think of any potential problems this might cause, but I'm unable to think of any scenario where it won't work. @bors r+ |
|
📌 Commit bd45ac8 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Feb 3, 2022
This was referenced Feb 8, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 9, 2022
Update cargo 5 commits in 25fcb135d02ea897ce894b67ae021f48107d522b..c082648646cbb2be266df9ecbcdc253058158d68 2022-02-01 01:32:48 +0000 to 2022-02-08 14:55:05 +0000 - Add rustup link (rust-lang/cargo#10371) - Improve startup time of bash completion. (rust-lang/cargo#10365) - Stabilize `-Ztimings` as `--timings` (rust-lang/cargo#10245) - Remove needless borrow (rust-lang/cargo#10360) - Compute non custom build and non transitive deps for doc (rust-lang/cargo#10341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
close #10318 and close #9198
How should we test and review this PR?
Compute non custom build and non transitive deps for doc.
Add test for it.