Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --scrape-examples-target-crate using package name (with dashes) instead of crate name (with underscores) #10037

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

willcrichton
Copy link
Contributor

This PR fixes #10035.

@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Nov 4, 2021

📌 Commit 7ee3ffc has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2021
@bors
Copy link
Collaborator

bors commented Nov 4, 2021

⌛ Testing commit 7ee3ffc with merge e3f2953...

@bors
Copy link
Collaborator

bors commented Nov 4, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing e3f2953 to master...

@bors bors merged commit e3f2953 into rust-lang:master Nov 4, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 9, 2021
Update cargo

4 commits in 94ca096afbf25f670e76e07dca754fcfe27134be..2e2a16e983f597da62bc132eb191bc3276d4b1bb
2021-10-29 14:45:06 +0000 to 2021-11-08 15:13:38 +0000
- Fix debug panic on download with redirect body. (rust-lang/cargo#10048)
- no need to clone (rust-lang/cargo#10051)
- Update curl. (rust-lang/cargo#10040)
- Fix --scrape-examples-target-crate using package name (with dashes) instead of crate name (with underscores) (rust-lang/cargo#10037)
@ehuss ehuss added this to the 1.58.0 milestone Feb 6, 2022
@weihanglo weihanglo added the Z-scrape-examples Nightly: rustdoc scrape examples label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. Z-scrape-examples Nightly: rustdoc scrape examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dash (-) in a crate name breaks rustdoc-scrape-examples
6 participants