Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish up Miri integration #376

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Conversation

Aaron1011
Copy link
Member

This PR gets all of the tests passing under Miri, and runs them on CI.

@Aaron1011
Copy link
Member Author

@alexcrichton: How do you want to handle the case where Miri is not available for a given channel?

@alexcrichton
Copy link
Member

Thanks for this! Could a new CI builder be added with a pinned nightly version to handle drift in miri?

@Aaron1011
Copy link
Member Author

@RalfJung What's the preferred way to handle this kind of thing? Is there a way to get Rustup to automatically install the most recent nightly that has Miri available?

@RalfJung
Copy link
Member

Is there a way to get Rustup to automatically install the most recent nightly that has Miri available?

Yes, it is described in our README:

MIRI_NIGHTLY=nightly-$(curl -s https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu/miri)
echo "Installing latest nightly with Miri: $MIRI_NIGHTLY"
rustup set profile minimal
rustup default "$MIRI_NIGHTLY"
rustup component add miri

@Aaron1011
Copy link
Member Author

@alexcrichton: This should be ready to merge

@alexcrichton alexcrichton merged commit a6dd47b into rust-lang:master Oct 15, 2020
@alexcrichton
Copy link
Member

👍

Aaron1011 added a commit to Aaron1011/rust that referenced this pull request Oct 15, 2020
This pulls in rust-lang/backtrace-rs#376, which
fixes Miri support for `std::backtrace::Backtrace`.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 16, 2020
…ark-Simulacrum

Bump backtrace-rs

This pulls in rust-lang/backtrace-rs#376, which
fixes Miri support for `std::backtrace::Backtrace`.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 16, 2020
…ark-Simulacrum

Bump backtrace-rs

This pulls in rust-lang/backtrace-rs#376, which
fixes Miri support for `std::backtrace::Backtrace`.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 16, 2020
…ark-Simulacrum

Bump backtrace-rs

This pulls in rust-lang/backtrace-rs#376, which
fixes Miri support for `std::backtrace::Backtrace`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants