Add plugins feature #392

brunoproduit · 2023-09-28T15:16:01Z

This PR activates full cmplog by compiling the afl++ llvm plugins and linking them into the target binaries.
This is activated via an added features "cmplog" as it needs nightly and llvm tools. It is not activated by default.

This fixes #323 .

brunoproduit · 2023-10-02T09:15:55Z

Pipelines seems to break at afl system-config and should probably be running cargo install --path . beforehand

smoelius · 2023-10-02T13:34:58Z

Thank you very much for this PR.

It's probably going to take a few rounds of review for me to understand all of what has changed, so please be patient with me.

I will start on this soon.

smoelius

Thanks a lot for doing this. I like the approach of using a Cargo feature.

Again, I may need to look at this a few times. So thanks in advance for your patience.

smoelius · 2023-10-05T09:13:32Z

afl/examples/cmplog.rs

@@ -26,6 +26,13 @@ fn main() {
            return;
        };

+        let slice = &data[16..27];


Suggested change

let slice = &data[16..27];

let slice = &data[16..];

I think the 27 version could panic(?), because data is only checked to be of length >= 24.

Changed in last commit

afl/examples/cmplog.rs

smoelius · 2023-10-05T09:32:46Z

cargo-afl/build.rs

+
+    let status = command
+        .status()
+        .expect("could not run 'git submodule update'");


Was the use of git submodule init added just as a convenience? Or is the answer more complicated than that?

I'm not 100% certain, but I think think will break when others try to download this from crates.io. As I learned recently, when you publish to crates.io, cargo takes a snapshot of the submodule directory, and then the fact that it is a submodule is forgotten.

Also, it looks like a bunch of code was deleted, e.g., code related to building on docs.rs. Was that intentional?

See my other comment on line 99

smoelius · 2023-10-05T09:43:43Z

cargo-afl/src/common.rs

+    let llvm_version = version_meta.llvm_version.unwrap().major.to_string();
+    let mut llvm_config = "llvm-config-".to_string();
+    llvm_config.push_str(&llvm_version);
+    llvm_config


Would this work?

format!("llvm-config-{llvm_version}")

Changed in the last commit

cargo-afl/src/common.rs

smoelius · 2023-10-05T09:59:18Z

cargo-afl/build.rs

        // skip the checks for the legacy x86 afl-gcc compiler
        .env("AFL_NO_X86", "1")
        // build just the runtime to avoid troubles with Xcode clang on macOS
-        .env("NO_BUILD", "1")
+        //.env("NO_BUILD", "1")


Note to self to revisit this.

cargo-afl/build.rs

cargo-afl/src/bin/cargo-afl.rs

smoelius · 2023-10-05T10:05:16Z

cargo-afl/src/bin/cargo-afl.rs

@@ -343,6 +376,9 @@ where
        .env("RUSTDOCFLAGS", &rustdocflags)
        .env("ASAN_OPTIONS", asan_options)
        .env("TSAN_OPTIONS", tsan_options)
+        .env("AFL_LLVM_INSTRUMENT", "PCGUARD")
+        .env("AFL_LLVM_CMPLOG", "1")
+        .env("AFL_QUIET", "1")


Shouldn't these be guarded by the cmplog feature?

If that's correct, then I would set these in the same if block above where the -Z flags were added.

Splitted this into a Hashmap to be included in the cmplog feature, let me know if that's more adequate

brunoproduit · 2023-10-06T08:41:11Z

Thanks a lot for the review! I'll take a look at it next week and make the requested changes

vanhauser-thc · 2023-10-06T15:04:41Z

Some context why this is something someone would want: it allows solving eg

                let slice16 = &data[20..36];
                let if_u128 = u128::from_le_bytes(slice16.try_into().unwrap());
                if secret_u128 != if_u128 { return; }

Plus the string matching you see added in the example plus floating point solving - all things that libfuzzer and honggfuzz can’t do.

brunoproduit · 2023-10-10T13:55:06Z

Did a first round of fixes for most of the conversations, let me know if I missed something. Could you take another look?

smoelius · 2023-10-16T08:25:00Z

cargo-afl/build.rs

+    if cfg!(feature = "cmplog") {
+        llvm_config = common::get_llvm_config();
+    }


Can this logic be moved inside build_afl (since llvm_config is not needed elsewhere)?

Done in the latest commit

smoelius · 2023-10-16T08:41:32Z

cargo-afl/build.rs

@@ -14,67 +13,75 @@ static AR_CMD: &str = "ar";
 mod common;

 fn main() {


It still appears to me that a bunch of logic was removed from this function:

afl.rs/build.rs

Lines 17 to 51 in 777a97b

let installing = home::cargo_home()

.map(|path| Path::new(env!("CARGO_MANIFEST_DIR")).starts_with(path))

.unwrap();

let out_dir = env::var("OUT_DIR").unwrap();

// smoelius: Build AFLplusplus in a temporary directory when installing or when building on docs.rs.

let work_dir = if installing || env::var("DOCS_RS").is_ok() {

let tempdir = tempfile::tempdir_in(&out_dir).unwrap();

if Path::new(AFL_SRC_PATH).join(".git").is_dir() {

let status = Command::new("git")

.args(["clone", AFL_SRC_PATH, &*tempdir.path().to_string_lossy()])

.status()

.expect("could not run 'git'");

assert!(status.success());

} else {

fs_extra::dir::copy(

AFL_SRC_PATH,

tempdir.path(),

&fs_extra::dir::CopyOptions {

content_only: true,

..Default::default()

},

)

.unwrap();

}

tempdir.into_path()

} else {

PathBuf::from(AFL_SRC_PATH)

};

let base = if env::var("DOCS_RS").is_ok() {

Some(PathBuf::from(out_dir))

} else {

None

};

I assume that was a mistake. Could you please re-add it?

This was initially because of the compilation errors we had and discussed before, all these have been reverted to the master branch's way. Done in the latest commit.

smoelius · 2023-10-16T08:45:00Z

cargo-afl/build.rs

+            "cargo-afl must be compiled with nightly for the cmplog feature"
+        );
+
+        // check if llvm tools are installed and with the good version for the plugin compilation


and with the good version

What does this comment refer to? It suggests the output of llvm-config --version should be checked. Is that missing?

cargo-afl/build.rs

smoelius · 2023-10-16T09:02:27Z

cargo-afl/build.rs

+        .arg(common::object_file_path(base))
+        .status()
+        .expect("could not run 'ar'");
+    assert!(status.success());


It looks like this use of ar was copied from build_afl_llvm_runtime by mistake?

Indeed, good catch, removed

smoelius · 2023-10-16T09:13:27Z

cargo-afl/src/bin/cargo-afl.rs

+        // Make sure we are on nightly for the -Z flags
+        assert!(
+            rustc_version::version_meta().unwrap().channel == rustc_version::Channel::Nightly,
+            "cargo-afl must be compiled with nightly for the cmplog feature"
+        );
+
+        let llvm_config = common::get_llvm_config();
+
+        // check if llvm tools are installed and with the good version for the plugin compilation
+        let mut command = Command::new(llvm_config.clone());
+        command.args(["--version"]);
+        let status = command
+            .status()
+            .unwrap_or_else(|_| panic!("could not run {llvm_config} --version"));
+        assert!(status.success());


This code appears nearly verbatim in build.rs. I think it is fine to perform these checks in just build.rs.

As you prefer, we wanted to make sure that the environment is the same when using it, let me remove that. I'll also put it in the build.rs instead of common.rs in that case

cargo-afl/src/bin/cargo-afl.rs

smoelius · 2023-10-16T09:18:09Z

cargo-afl/build.rs

@@ -94,6 +101,33 @@ fn build_afl_llvm_runtime(work_dir: &Path, base: Option<&Path>) {
    assert!(status.success());
 }

+fn build_afl_llvm_plugins(work_dir: &Path, base: Option<&Path>) {


Suggested change

fn build_afl_llvm_plugins(work_dir: &Path, base: Option<&Path>) {

fn copy_afl_llvm_plugins(work_dir: &Path, base: Option<&Path>) {

Nit, since the pluigns were actually built in build_afl.

Done in the latest commit

cargo-afl/src/bin/cargo-afl.rs

smoelius · 2023-10-16T09:25:05Z

cargo-afl/src/bin/cargo-afl.rs

+            -Z llvm-plugins={p}/cmplog-routines-pass.so \
+            -Z llvm-plugins={p}/cmplog-switches-pass.so \
+            -Z llvm-plugins={p}/SanitizerCoveragePCGUARD.so
+             "


Suggested change

"

"

Nit.

Done in the latest commit

smoelius · 2023-10-16T09:30:55Z

Thanks for your continued patience, @brunoproduit.

brunoproduit · 2023-10-17T10:13:31Z

No problem! @smoelius If you could take yet another look, I should have resolved all the new conversations

smoelius · 2023-10-17T16:36:47Z

I'm likely going to request more changes, but I want to be sure this is going to work in CI.

So, I'm going to push to your branch. But I won't touch any files that you've modified. Ok?

smoelius · 2023-10-18T10:14:58Z

I need to find the right syntax for the GitHub matrix and macOS's sed. I'll get back to this soon.

smoelius · 2023-10-19T00:19:46Z

When I brew install llvm@17 on a Mac, I get an llvm-config but not an llvm-config-17.

Mac is a platform that we support, and I expect many Mac users will install llvm with Homebrew.

Could you please adjust the build script so that llvm-config-17 is not required (at least not on macOS)?

brunoproduit · 2023-10-19T09:02:57Z

We do need to check that the major version matches the rustc llvm version, else it won't work. I'll set an if that sets LLVM_CONFIG to "llvm-config" on Mac and check that the major version corresponds (by catching the output of the --version). later this week if that works for you

smoelius · 2023-10-19T09:11:40Z

I'll set an if that sets LLVM_CONFIG to "llvm-config" on Mac and check that the major version corresponds (by catching the output of the --version). later this week if that works for you

That sounds perfect. Thank you!

brunoproduit · 2023-10-23T09:35:38Z

Did the change and refactored a bit around it. Also it now only sets LLVM_CONFIG if cmplog is activated

smoelius · 2023-10-23T23:58:32Z

I'm going to push more changes to rust.yml, but I will stay out of your code.

vanhauser-thc · 2023-10-25T14:24:18Z

btw I added support for two advanced features:

dict2file: generates a valid dictionary on the fly during compilation (needs AFL_LLVM_DICT2FILE=/file/to/create.txt set), this has shown on fuzzbench to be a major improvement to unlock coverage
selective coverage: only instrument for fuzzing specific functions or files for fuzzing - or specifically not instrument for fuzzing.

also in tests I see that using the AFL++ instrumentation module vs. the llvm sancov creates a x2 speed increase (without any drawbacks and an even better coverage gathering).

smoelius · 2023-10-25T15:22:23Z

@brunoproduit I'm pushing to your branch to get the fix for AFLplusplus/AFLplusplus#1898.

brunoproduit · 2023-10-26T08:46:06Z

Should we change the feature name to something else now that this activates more than cmplog?
What about something like "llvm-afl-plugins"?

smoelius · 2023-10-26T11:05:56Z

Should we change the feature name to something else now that this activates more than cmplog? What about something like "llvm-afl-plugins"?

Oh, I didn't make that connection.

What is the full list of "features"? (I'm wondering if it would make sense to enable them independently.)

Separately, I am trying to diagnose why the shared libraries cannot be loaded on macOS (see here). From what I can tell, it's not a path problem, i.e., I expect that /Users/runner/.../cmplog-instructions-pass.so exists, as I observe the same failure locally.

Please share if you know what the cause could be.

brunoproduit · 2023-10-26T15:42:07Z

Features are

Cmplog
dict2file
partial instrumentation
Faster fuzzing due to the AFL++ instrumentation module instead of the llvm sancov

IMO, we shouldn't separate as they all have the same requirements. Either you want to add addons from AFL, or not.
The only thing is you need nightly and LLVM, which is why a feature is nice.

Haven't had time to take a look at the macos issue yet, sorry

smoelius · 2023-10-26T16:11:41Z

Features are

Cmplog

dict2file

partial instrumentation

Faster fuzzing due to the AFL++ instrumentation module instead of the llvm sancov

Thanks.

IMO, we shouldn't separate as they all have the same requirements. Either you want to add addons from AFL, or not. The only thing is you need nightly and LLVM, which is why a feature is nice.

I'm not sure I agree, but we don't have to decide this now. I agree that "llvm-afl-plugins" would be a better feature name.

vanhauser-thc · 2023-10-27T06:57:54Z

Can we please shorten the flag to “plugins”? Imho it is too long otherwise

smoelius · 2023-10-27T10:45:15Z

Can we please shorten the flag to “plugins”? Imho it is too long otherwise

That works for me.

smoelius · 2023-10-27T22:15:24Z

Separately, I am trying to diagnose why the shared libraries cannot be loaded on macOS (see here). From what I can tell, it's not a path problem, i.e., I expect that /Users/runner/.../cmplog-instructions-pass.so exists, as I observe the same failure locally.

This is the error I get locally:

Could not load library '/Users/[snip]/cmplog-instructions-pass.so': dlopen(/Users/[snip]/cmplog-instructions-pass.so, 0x0009): symbol not found in flat namespace '__ZN4llvm17PreservedAnalyses14AllAnalysesKeyE'

smoelius · 2023-10-28T11:30:51Z

@vanhauser-thc Can I ask why AFLplusplus's macos-latest tests are disabled?

vanhauser-thc · 2023-10-29T08:28:01Z

@vanhauser-thc Can I ask why AFLplusplus's macos-latest tests are disabled?

Because there are often unpredictable changes. Eg Apple change how to preload libraries and supporting this would be quite an effort. Or the he crippled Xcode clang. And brew llvm also changes from time to time how it behaves. Finally GitHub’s mac container also changes sometimes where otherwise it works perfectly on my Mac mini.
So making the CI work is quite an effort.
I am not a Mac user and few people fuzz on Mac (bad performance of clone for example) hence I rather fix stuff it I get a report something is not working.

smoelius · 2023-10-31T01:41:53Z

In GNUmakefile.llvm, if I change this line:

  CLANG_LFL += -Wl,-flat_namespace -Wl,-undefined,suppress

to this one:

  CLANG_LFL += -Wl,-flat_namespace -Wl,-undefined,suppress `$(LLVM_CONFIG) --libs`

I get a different error:

Assertion failed: (AnalysisPasses.count(PassT::ID()) && "This analysis pass was not registered prior to being queried"), function getResult, file PassManager.h, line 776.

Does this mean anything to you? @brunoproduit @vanhauser-thc

vanhauser-thc · 2023-10-31T08:43:40Z

MacOS is difficult. brew needs to install the right llvm version, there all the time changes in brew and Mac - for me as a non-user of MacOS it is very difficult to be on top of this.
Hence there is no full MacOS support for AFL++ and only act on things if people report issues.

I would simply propose to not support the plugin feature for MacOS, someone can do it by hand if they want to,.
Handling all the CI failures that will creep up again and again over the time is not worth it IMHO

vanhauser-thc · 2023-11-01T13:41:01Z

@smoelius please note that I changed the output of the --version command. IHMO it is important to see if afl.rs was compiled normal or with the plugins feature. if you want it to look different, just edit away or tell me how else you would like it :)

smoelius

I think once these changes are made, this should be mergeable.

smoelius · 2023-11-01T22:25:12Z

cargo-afl/src/bin/cargo-afl.rs

+        concat!($s1, $s2)
+    };
+}
+
 #[allow(clippy::too_many_lines)]
 fn clap_app() -> clap::Command {
    use clap::{value_parser, Arg, Command};

    let help = "In addition to the subcommands above, Cargo subcommands are also \


Suggested change

let help = "In addition to the subcommands above, Cargo subcommands are also \

const HELP: &str = "In addition to the subcommands above, Cargo subcommands are also \

And then change help to HELP below. That should make Clippy happy.

Handled in https://github.com/brunoproduit/afl.rs/commit/a6716abf6d03e946b3b95b818ead35e31bcb2dc6

smoelius · 2023-11-01T22:25:46Z

cargo-afl/src/bin/cargo-afl.rs

 #[allow(clippy::too_many_lines)]
 fn clap_app() -> clap::Command {
    use clap::{value_parser, Arg, Command};

    let help = "In addition to the subcommands above, Cargo subcommands are also \
                      supported (see `cargo help` for a list of all Cargo subcommands).";

+    const VERSION: &'static str = if cfg!(feature = "plugins") {


Suggested change

const VERSION: &'static str = if cfg!(feature = "plugins") {

const VERSION: &str = if cfg!(feature = "plugins") {

Again, make Clippy happy.

Handled in https://github.com/brunoproduit/afl.rs/commit/a6716abf6d03e946b3b95b818ead35e31bcb2dc6

smoelius · 2023-11-01T22:38:15Z

cargo-afl/build.rs

+    if cfg!(feature = "plugins") {
+        let llvm_config = check_llvm_and_get_config();
+        environment_variables.insert("LLVM_CONFIG".to_string(), llvm_config);
+    }


Rather than create a hash table, please move this if-statement below and modify command directly. Something like:

if cfg!(feature = "plugins") { let llvm_config = check_llvm_and_get_config(); command.env("LLVM_CONFIG", llvm_config); }

Handled in https://github.com/brunoproduit/afl.rs/commit/a6716abf6d03e946b3b95b818ead35e31bcb2dc6

smoelius · 2023-11-01T22:40:01Z

cargo-afl/build.rs

+
+    let status = command
+        .status()
+        .expect("could not run 'make clean, make install'");


Suggested change

.expect("could not run 'make clean, make install'");

.expect("could not run 'make clean install'");

Nit. Technically, it's one command.

Handled in https://github.com/brunoproduit/afl.rs/commit/a6716abf6d03e946b3b95b818ead35e31bcb2dc6

smoelius · 2023-11-01T22:46:09Z

cargo-afl/build.rs

+        "split-compares-pass.so",
+        "split-switches-pass.so",
+        "SanitizerCoveragePCGUARD.so",
+    ];


These are all of the .so files that are built, correct? Would it make sense to loop over all of the files using read_dir, and then copy those with an so extension? Or, is there a good argument for listing the files explicitly?

The idea was to fix those for readability and future-proofing, like if we want to exclude certain so's in the future. I changed this in the last commit

smoelius · 2023-11-01T22:48:14Z

cargo-afl/src/bin/cargo-afl.rs

 #[allow(clippy::too_many_lines)]
 fn clap_app() -> clap::Command {
    use clap::{value_parser, Arg, Command};

    let help = "In addition to the subcommands above, Cargo subcommands are also \
                      supported (see `cargo help` for a list of all Cargo subcommands).";

+    const VERSION: &'static str = if cfg!(feature = "plugins") {
+        concat_str!(env!("CARGO_PKG_VERSION"), " [feature=plugins]")


Suggested change

concat_str!(env!("CARGO_PKG_VERSION"), " [feature=plugins]")

concat!(env!("CARGO_PKG_VERSION"), " [feature=plugins]")

And remove the concat_str macro above.

fixed in the last commit

smoelius · 2023-11-01T22:52:50Z

cargo-afl/build.rs

 }

 fn build_afl(work_dir: &Path, base: Option<&Path>) {
+    let mut environment_variables = HashMap::<String, String>::new();


Suggested change

let mut environment_variables = HashMap::<String, String>::new();

See comment just below this one.

fixed in the last commit

smoelius · 2023-11-01T22:53:37Z

cargo-afl/build.rs

+        "DESTDIR".to_string(),
+        common::afl_dir(base).to_str().unwrap().to_string(),
+    );
+    environment_variables.insert("PREFIX".to_string(), String::new());


Please set these directly on command (like before).

fixed in the last commit

smoelius · 2023-11-01T23:07:57Z

cargo-afl/src/bin/cargo-afl.rs

    );
+    let mut environment_variables = HashMap::<String, String>::new();


Suggested change

let mut environment_variables = HashMap::<String, String>::new();

let mut environment_variables = HashMap::<&str, String>::new();

I think all of the keys are strs, so this should work. Note that the inserts below will need to be adjusted.

fixed in the last commit

brunoproduit · 2023-11-08T13:46:09Z

Applied the requested changes in the last commit, could take a look @smoelius ?

smoelius · 2023-11-10T01:05:12Z

@brunoproduit Could you please resolve the conflicts?

If it's easiest, you can squash all of the commits down to one. (I would like to squash before rebasing anyway.)

brunoproduit · 2023-11-10T13:26:56Z

@smoelius done, you can go ahead and merge/squash it

smoelius · 2023-11-11T12:26:57Z

Thank you, @brunoproduit.

smoelius · 2023-11-19T11:51:50Z

@vanhauser-thc @brunoproduit #421 impacts the feature introduced by this PR.

Could I impose on one or both of you try #421, and let me know if there are any suprises?

brunoproduit · 2023-11-20T10:50:05Z

I'll try it out this week, I like the idea

jberryman · 2024-02-12T20:23:27Z

dict2file: generates a valid dictionary on the fly during compilation (needs AFL_LLVM_DICT2FILE=/file/to/create.txt set), this has shown on fuzzbench to be a major improvement to unlock coverage
selective coverage: only instrument for fuzzing specific functions or files for fuzzing - or specifically not instrument for fuzzing.

it would be super helpful if this stuff was in the README or somewhere prominent.

kevin-valerio · 2024-06-25T11:23:25Z

Separately, I am trying to diagnose why the shared libraries cannot be loaded on macOS (see here). From what I can tell, it's not a path problem, i.e., I expect that /Users/runner/.../cmplog-instructions-pass.so exists, as I observe the same failure locally.

This is the error I get locally:

Could not load library '/Users/[snip]/cmplog-instructions-pass.so': dlopen(/Users/[snip]/cmplog-instructions-pass.so, 0x0009): symbol not found in flat namespace '__ZN4llvm17PreservedAnalyses14AllAnalysesKeyE'

Hey. I'm having the same error here. How did you fix it, do you remember ?

smoelius · 2024-06-25T11:58:22Z

@kevin-valerio I never was able to resolve this issue. (See #392 (comment).) That is why plugins are not tested on macOS in CI:

afl.rs/.github/workflows/rust.yml

Lines 38 to 39 in 425b419

    
           - environment: macos-latest 
        
             plugins: true

I just checked and I still experience the issue. FWIW, I would love to have help with this.

vanhauser-thc · 2024-06-25T16:16:50Z

Are you sure the plugins are compiled with the correct clang from brew? Xcode clang is crippled and the brew llvm version must match the version rust is based on (currently 18)

kevin-valerio · 2024-06-26T09:15:03Z

Are you sure the plugins are compiled with the correct clang from brew? Xcode clang is crippled and the brew llvm version must match the version rust is based on (currently 18)

❯ rustc --version --verbose
rustc 1.81.0-nightly (6b0f4b5ec 2024-06-24)
LLVM version: 18.1.7

❯ brew info llvm
==> llvm: stable 18.1.7 (bottled), HEAD [keg-only]

❯ which clang
/opt/homebrew/opt/llvm/bin/clang

❯ which llvm-ar
/opt/homebrew/opt/llvm/bin/llvm-ar

Everything seem to match for me unfortunately

vanhauser-thc · 2024-06-26T10:49:05Z

Then likely brew updated llvm to a slightly newer minor revision at a later point so you need to recompile the plugins …

cargo afl config —plugins —force

vanhauser-thc · 2024-06-26T10:51:30Z

Another possibility is that brew llvm and macOS rustc llvm are compiled very differently and the plugins are incompatible. You could experiment switching to a different nightly

brunoproduit marked this pull request as draft September 28, 2023 15:17

brunoproduit marked this pull request as ready for review October 2, 2023 09:13

smoelius requested changes Oct 5, 2023

View reviewed changes

smoelius requested changes Oct 16, 2023

View reviewed changes

smoelius mentioned this pull request Oct 24, 2023

Delays related to 6b73dee AFLplusplus/AFLplusplus#1898

Closed

smoelius reviewed Nov 2, 2023

View reviewed changes

smoelius approved these changes Nov 11, 2023

View reviewed changes

smoelius changed the title ~~Activate full cmplog~~ Activate plugins feature Nov 11, 2023

smoelius changed the title ~~Activate plugins feature~~ Add plugins feature Nov 11, 2023

Add plugins feature

51b2cf9

smoelius merged commit 785db30 into rust-fuzz:master Nov 11, 2023
12 checks passed

a1akris mentioned this pull request Dec 13, 2023

Plugins feature breaks afl build? #434

Closed

smoelius mentioned this pull request Jan 15, 2024

Do not pass -C passes=... when nightly is used and plugins are compiled #449

Merged

		@@ -14,67 +13,75 @@ static AR_CMD: &str = "ar";
		mod common;

		fn main() {

	let installing = home::cargo_home()
	.map(\|path\| Path::new(env!("CARGO_MANIFEST_DIR")).starts_with(path))
	.unwrap();
	let out_dir = env::var("OUT_DIR").unwrap();

	// smoelius: Build AFLplusplus in a temporary directory when installing or when building on docs.rs.
	let work_dir = if installing \|\| env::var("DOCS_RS").is_ok() {
	let tempdir = tempfile::tempdir_in(&out_dir).unwrap();
	if Path::new(AFL_SRC_PATH).join(".git").is_dir() {
	let status = Command::new("git")
	.args(["clone", AFL_SRC_PATH, &*tempdir.path().to_string_lossy()])
	.status()
	.expect("could not run 'git'");
	assert!(status.success());
	} else {
	fs_extra::dir::copy(
	AFL_SRC_PATH,
	tempdir.path(),
	&fs_extra::dir::CopyOptions {
	content_only: true,
	..Default::default()
	},
	)
	.unwrap();
	}
	tempdir.into_path()
	} else {
	PathBuf::from(AFL_SRC_PATH)
	};

	let base = if env::var("DOCS_RS").is_ok() {
	Some(PathBuf::from(out_dir))
	} else {
	None
	};

	fn build_afl_llvm_plugins(work_dir: &Path, base: Option<&Path>) {
	fn copy_afl_llvm_plugins(work_dir: &Path, base: Option<&Path>) {

	let help = "In addition to the subcommands above, Cargo subcommands are also \
	const HELP: &str = "In addition to the subcommands above, Cargo subcommands are also \

	const VERSION: &'static str = if cfg!(feature = "plugins") {
	const VERSION: &str = if cfg!(feature = "plugins") {

	.expect("could not run 'make clean, make install'");
	.expect("could not run 'make clean install'");

	concat_str!(env!("CARGO_PKG_VERSION"), " [feature=plugins]")
	concat!(env!("CARGO_PKG_VERSION"), " [feature=plugins]")

		);
		let mut environment_variables = HashMap::<String, String>::new();

Add plugins feature #392

Add plugins feature #392

Conversation

brunoproduit commented Sep 28, 2023

brunoproduit commented Oct 2, 2023

smoelius commented Oct 2, 2023

smoelius left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brunoproduit commented Oct 6, 2023

vanhauser-thc commented Oct 6, 2023 • edited Loading

brunoproduit commented Oct 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brunoproduit Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smoelius commented Oct 16, 2023

brunoproduit commented Oct 17, 2023

smoelius commented Oct 17, 2023

smoelius commented Oct 18, 2023

smoelius commented Oct 19, 2023

brunoproduit commented Oct 19, 2023

smoelius commented Oct 19, 2023

brunoproduit commented Oct 23, 2023

smoelius commented Oct 23, 2023

vanhauser-thc commented Oct 25, 2023

smoelius commented Oct 25, 2023

brunoproduit commented Oct 26, 2023

smoelius commented Oct 26, 2023 • edited Loading

brunoproduit commented Oct 26, 2023

smoelius commented Oct 26, 2023

vanhauser-thc commented Oct 27, 2023

smoelius commented Oct 27, 2023

smoelius commented Oct 27, 2023

smoelius commented Oct 28, 2023

vanhauser-thc commented Oct 29, 2023

smoelius commented Oct 31, 2023

vanhauser-thc commented Oct 31, 2023

vanhauser-thc commented Nov 1, 2023

smoelius left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brunoproduit commented Nov 8, 2023

smoelius commented Nov 10, 2023

brunoproduit commented Nov 10, 2023

vanhauser-thc commented Oct 6, 2023 •

edited

Loading

brunoproduit commented Oct 10, 2023 •

edited

Loading

brunoproduit Oct 17, 2023 •

edited

Loading

smoelius commented Oct 26, 2023 •

edited

Loading

vanhauser-thc commented Jun 25, 2024 •

edited

Loading

vanhauser-thc commented Jun 26, 2024 •

edited

Loading