Use local directories when building for docs.rs #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't tested it, but this code should be enough to get `afl` to compile for docs.rs See https://docs.rs/crate/afl/0.10.0/builds/351937 for the current errors.
|
https://docs.rs/crate/afl/0.10.1/builds/394574 Looks like it didn't work |
|
Alright, I'll try and get docs.rs building on my machine, though it's odd that it's failing on the same line, I thought the cfg predicate for docs.rs builds was |
|
The docs.rs documentation states that any file writes should be made in the directory indicated by the |
|
@AlexTMjugador I'm not FWIW as I'm currently a bit overloaded at the moment. If you'd like to take over go ahead 🙂 |
smoelius
pushed a commit
that referenced
this pull request
May 9, 2022
This change addresses the same problem as #185. It turns out that build scripts are only meant to write to OUT_DIR, and in general it is untidy to write things all over the place. docs.rs is specially sensitive to this. Also, docs.rs does not set the feature flag "docsrs" by itself, but a Cargo package metadata section can be used to instruct docs.rs to pass that flag to Cargo.
|
I think this is finally working: https://docs.rs/afl/0.12.8/afl/index.html Thanks @XAMPPRocky and @AlexTMjugador for all of your research into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested it, but this code should be enough to get
aflto compile for docs.rsSee https://docs.rs/crate/afl/0.10.0/builds/351937 for the current errors. This will require a new release to test.