Add restore-state-usize #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing restore-state-* options all go for concrete sizes; this adds an option that goes for usize (however large that may be on a platform).
This is an odd choice at first glance -- a typical implementation will be bound to an architecture and thus know the width of their usize anyway. However, when porting to a portable operating system (such as RIOT OS), the state that needs to be persisted may be defined as usize (or, in the case of RIOT OS, C's int type). Sure it might be possible to fan out somewhere in the build system and enable the right features on the right platforms, but given how cargo's graph resolution works, this needs cumbersome out-of-cargo setups, so providing a usize restore state appears to be the cleanest way forward.