Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement public key ordering using underlying FFI functions #449

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Re-implement public key ordering using underlying FFI functions #449

merged 4 commits into from
Jun 15, 2022

Commits on Jun 14, 2022

  1. FFI for pubkey comparison ops

    @dr-orlovsky @tcharding
    dr-orlovsky authored and tcharding committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    999d165 View commit details
    Browse the repository at this point in the history

  2. Benchmark for key ordering

    @dr-orlovsky @tcharding
    dr-orlovsky authored and tcharding committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    0faf404 View commit details
    Browse the repository at this point in the history

  3. Implement PublicKey ordering using FFI 

    Instead of selializing the key we can call down to the ffi layer to do
ordering.

Co-authored-by: Tobin C. Harding <me@tobin.cc>
    @dr-orlovsky @tcharding
    dr-orlovsky and tcharding committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    7396604 View commit details
    Browse the repository at this point in the history

  4. Make key comparison non-fuzzable 

    Feature guard the custom implementations of `Ord` and `PartialOrd` on
`cfg(not(fuzzing))`. When fuzzing, auto-derive implementations.

Co-authored-by: Tobin C. Harding <me@tobin.cc>
    @dr-orlovsky @tcharding
    dr-orlovsky and tcharding committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    13af519 View commit details
    Browse the repository at this point in the history