-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
index out of range panic in scanLinkRef #172
Comments
tw4452852
added a commit
to tw4452852/blackfriday
that referenced
this issue
Jun 8, 2015
Add checking before accessing the input data. Fix russross#172 and russross#173 issues. Signed-off-by: Tw <tw19881113@gmail.com>
dmitshur
added a commit
that referenced
this issue
Jul 15, 2016
These will be helpful for catching regressions or changes in behavior to edge cases such as empty input, or specifically crafted inputs that may cause panics, etc. Move test for issue #172 there since it's a document-level test, not an inline one. Add test for issue #173. Make some things more consistent. Don't use a named receiver in methods that don't use it. This makes the code more readable since one can more quickly tell the inputs to the method.
rtfb
added a commit
that referenced
this issue
Feb 12, 2017
The check was introduced with d28de22, when fixing #172 and #173. Then I removed it with bcd6dd8 when fixing #180 And then it was reintroduced with 232d06c when fixing regression. It seems that the check can be removed again. All these cases now have tests (including the one from 69f51af, which seems to have landed to v1 only, copying it here) and they all pass.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
The below program panics:
The text was updated successfully, but these errors were encountered: