Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32-bit and big-endian builds #290

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Fix 32-bit and big-endian builds #290

merged 6 commits into from
Aug 28, 2024

Conversation

darkk
Copy link
Contributor

@darkk darkk commented Aug 28, 2024

That's a few small fixes those should be easy to review.

I'm submitting them separately to shorten the next PR that'll focus on better SpeedTest reporting and MIPS32 cycle counter.

@darkk
Copy link
Contributor Author

darkk commented Aug 28, 2024

Failures are the same as they were in #289 (comment)

@rurban rurban merged commit de06b48 into rurban:master Aug 28, 2024
6 of 10 checks passed
@rurban
Copy link
Owner

rurban commented Aug 28, 2024

macOS PMP_Multilinear.h:1421:6: error: no viable overloaded '+='
and windows should really be fixed somewhen...

@darkk
Copy link
Contributor Author

darkk commented Aug 28, 2024

windows should really be fixed somewhen

Speaking of... I've got 32-bit BE, 64-big BE and 32-bit LE machines and I see lots of failures. What's the best way to deal with them? I mean, I can do "my" best, but I'd like to know your opinion before submitting PR :-)

That's usual x86_64:

i7-6600U(64le)$ build/SMHasher --test=VerifyAll --verbose | awk '/Verification/ {print $7}' | sort | uniq -c
      4 INSECURE
    193 PASS
     37 SKIP

MIPS32, LE:

snr(32le)$ /tmp/SMHasher --test=VerifyAll | awk '/Verification/ {print $7}' | sort | uniq -c
      3 FAIL!
      8 INSECURE
    142 PASS
     21 SKIP

And MIPS32, Big Endian:

tp842(32be)$ /tmp/SMHasher --test=VerifyAll | awk '/Verification/ {print $7}' | sort | uniq -c 
    117 FAIL!
     10 INSECURE
     26 PASS
     19 SKIP

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants