Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finch Icon doesn't show up on GitHub iPhone App #56

Closed
ChandruShetty opened this issue Nov 26, 2022 · 2 comments · Fixed by #61
Closed

Finch Icon doesn't show up on GitHub iPhone App #56

ChandruShetty opened this issue Nov 26, 2022 · 2 comments · Fixed by #61
Assignees
@weikequ
Labels
bug Something isn't working

Comments

@ChandruShetty
Copy link
Contributor

ChandruShetty commented Nov 26, 2022 •
edited
Loading

Describe the bug
Finch logo is blank in the GitHub App finch repository.

Steps to reproduce

  1. Open GitHub app on your iPhone.
  2. Go to finch repository.
  3. Check the read me section.
  4. Finch logo/icon is blank.

Expected behavior
Finch icon is displayed.

Screenshots or logs
If applicable, add screenshots or logs to help explain your problem.

imageAdditional context
Add any other context about the problem here.
@ChandruShetty ChandruShetty added the bug Something isn't working label Nov 26, 2022
@weikequ weikequ mentioned this issue Nov 29, 2022
Merged
1 task
@weikequ
Copy link
Contributor

weikequ commented Nov 29, 2022

Seems like a standing issue. See:

weikequ added a commit that referenced this issue Nov 29, 2022
@weikequ
docs: changed svg ref to be absolute (#61)
1c99e74 
Signed-off-by: Weike Qu <weikequ@amazon.com>

Issue #, if available:
- Fixes #56

*Description of changes:*
- Updated the svg paths to be absolute paths to render correctly on ios
mobile apps.

*Testing done:*
- Checked issue was resolved on the app.



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Weike Qu <weikequ@amazon.com>
@ChandruShetty
Copy link
Contributor Author

Thanks for taking care of this. Icon now shows up in the GitHub App.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weikequ weikequ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix-svg-icon-mobile weikequ/finch
docs: Changed svg ref to be absolute weikequ/finch
2 participants
@ChandruShetty @weikequ