Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix #652 , Bitbucket Cloud GDPR Changes #654

Closed
wants to merge 2 commits into from

Conversation

nutellinoit
Copy link

As @Phylu stated:

https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-gdpr/

I changed bitbucket cloud merge logic using account_id instead of username.
Tested against real repository using self approval (with correct apply failed) and other users approval.

I can't try on bitbucket server...

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #654 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #654      +/-   ##
=========================================
+ Coverage   72.19%   72.2%   +<.01%     
=========================================
  Files          61      61              
  Lines        4643    4644       +1     
=========================================
+ Hits         3352    3353       +1     
  Misses       1045    1045              
  Partials      246     246
Impacted Files Coverage Δ
server/events/models/models.go 74.6% <ø> (ø) ⬆️
server/events/vcs/bitbucketcloud/client.go 39.51% <100%> (ø) ⬆️
server/events/event_parser.go 88.01% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 354551d...2cafcf6. Read the comment docs.

@lkysow
Copy link
Member

lkysow commented Jun 3, 2019

Hi Samuele,
I fixed this with #657 where I just used the response from the pull request API call rather than carrying the UUID field throughout the codebase.

Thanks for the PR and I apologize for not working through a review with you and just making the changes myself. I thought that since this is an issue preventing users from using Atlantis that speed was of the essence.

@lkysow lkysow closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants