Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix broken formatting of first comment in case of command output truncation #4980

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: fix broken formatting of first comment in case of command output truncation #4980

wants to merge 2 commits into from
+2 −1

Conversation

benoittoulme
Copy link
Contributor

@benoittoulme benoittoulme commented Oct 4, 2024 •
edited
Loading

what

  • fix the wrapping of the comments to make it collapsible in case of truncation of the command output.

why

  • in a previous PR, I introduced a markdown to display a warning message in case of truncation of a command output
    chore: use markdown to display github comments truncation header #4885
  • Because of the truncation of the command output, we are missing the <details> wrapping, that allows to display the rest of the message properly. My previous PR attempted to fix the formatting and worked in my tests, unfortunately, it missed re-introducing the wrapping.
  • This causes the first comment to display entirely in case of truncation of the command output, instead of appearing collapsed.

tests

deployed atlantis 0.30.0 and tested the comment markdown on a github comment.

references

@benoittoulme benoittoulme requested review from a team as code owners October 4, 2024 07:45
@benoittoulme benoittoulme requested review from jamengual, nitrocode and X-Guardian and removed request for a team October 4, 2024 07:45
@github-actions github-actions bot added go Pull requests that update Go code provider/github labels Oct 4, 2024
@benoittoulme benoittoulme changed the title fix broken formatting fix broken formatting of first comment in case of command output truncation Oct 4, 2024
@dosubot dosubot bot added the bug Something isn't working label Oct 4, 2024
@benoittoulme benoittoulme changed the title fix broken formatting of first comment in case of command output truncation chore: fix broken formatting of first comment in case of command output truncation Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from runatlantis/maintainers

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from runatlantis/core-contributors

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working go Pull requests that update Go code provider/github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benoittoulme