fix(docs): Fix Content-Security-Policy (CSP) rules for website #4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jippi
requested review from
GenPage,
lukemassa and
X-Guardian
and removed request for
a team
jippi
force-pushed
the
fix-netlify-headers
branch
10 times, most recently
from
1ac20e8
to
2fd44b6
Compare
jippi
force-pushed
the
fix-netlify-headers
branch
3 times, most recently
from
bb8d495
to
fd614a5
Compare
jippi
changed the title
jippi
force-pushed
the
fix-netlify-headers
branch
from
fd614a5
to
a9e16c8
Compare
X-Guardian
approved these changes
May 15, 2024
|
Considering there are no auth or PII on the site, I wonder if it would be simpler to just not enforce CSP to begin with though 🤔 |
|
It is done now, and it protects against malicious third party script injections. |
|
Are you happy for me to merge? |
chenrui333
approved these changes
May 15, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Fix Content-Security-Policy (CSP) errors on the new site.
Considering there are no auth or PII on the site, I wonder if it would be simpler to just not enforce CSP to begin with though 🤔
Preview site: https://deploy-preview-4567--runatlantis.netlify.app/