Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Sort results in command builder before comparing #4385

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

lukemassa
Copy link
Contributor

@lukemassa lukemassa commented Mar 26, 2024

what

Sort results of builder.BuildAutoplanCommands before comparing to expected values in tests.

why

The tests are currently flakey, per: #4363 (comment).

A potential follow up might be to have BuildAutoplanCommands return a sorted list, but that might have more implications so I'll leave that for now.

tests

make test now consistently passes.

references

@lukemassa lukemassa requested review from a team as code owners March 26, 2024 17:18
@lukemassa lukemassa requested review from jamengual, nitrocode and X-Guardian and removed request for a team March 26, 2024 17:18
@github-actions github-actions bot added the go Pull requests that update Go code label Mar 26, 2024
GenPage
GenPage previously approved these changes Mar 26, 2024
@lukemassa lukemassa merged commit e846d90 into runatlantis:main Mar 26, 2024
23 of 24 checks passed
@marcoceppi
Copy link
Contributor

Thanks for this. Golang is a very new language for me and the amount of time I spent on these tests alone I'd rather not say 😅

@nitrocode nitrocode changed the title fix: Sort results in command builder before comparing fix(tests): Sort results in command builder before comparing Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants