Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing test flags #4064

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

lukemassa
Copy link
Contributor

what

Add a number of missing flags to testFlags.

why

These are supposed to be added when users add new flags, looks like they were just omitted.

I opened #4063 to address the larger issue of preventing this drift in the future, this just does a backfill.

All the defaults are taken from server.go.

tests

Unit tests passing should be sufficient, this is just for completeness.

references

Partially addresses: #4063

@lukemassa lukemassa requested a review from a team as a code owner December 16, 2023 21:07
@lukemassa lukemassa changed the title Add missing test flags feat: Add missing test flags Dec 16, 2023
@github-actions github-actions bot added the go Pull requests that update Go code label Dec 16, 2023
@lukemassa
Copy link
Contributor Author

Tests are failing because main itself is broken, looking into this now

@jamengual
Copy link
Contributor

/cherry-pick release-0.27

@jamengual jamengual merged commit a828ee8 into runatlantis:main Dec 18, 2023
24 checks passed
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants