fix: fix unmarshall error in graphql call #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondchen625
changed the title
chenrui333
reviewed
Mar 8, 2022
chenrui333
changed the title
|
@raymondchen625 could you check the lint errors? Thanks |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* Fix unmarshall error in GraphQL call runatlantis#2090 * Add unit tests for GetTeamNamesForUser * Fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #2090 by using the right client from shurcooL's library.
Notes: By using GraphQL new scopes
['read:org', 'read:discussion']are required by the OAuth token. C.f. https://docs.github.com/en/graphql/guides/forming-calls-with-graphql