fix(gitlab-client): change pending to running state
#1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm unfortunately this doesn't seem be working either 🤔 |
|
The
It also properly transitions to failed in case the apply fails:
|
chenrui333
approved these changes
Jan 15, 2022
|
@syphernl is this working consistently for you right now? |
For me it is working as expected. |
|
Thanks @syphernl! |
|
looks like the tests failed in the master build. 😮💨 |
|
interesting, the tests did not actually got triggered for this PR. |
chenrui333
added a commit
that referenced
this pull request
Mar 7, 2022
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
added a commit
that referenced
this pull request
Mar 7, 2022
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* fix(gitlab-client): change pending to running state * change default state
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…2120) Signed-off-by: Rui Chen <rui@chenrui.dev>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitLab API does not permit the pipeline state to go from
pendingtosuccesswithout going troughrunningfirst.It does not appear that we actually need to use the
pendingstate at all, insteadrunningcan be used which should resolve this issue.Fixes #1356