Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add clarity and further policy_check examples #1925

Merged

Conversation

davehewy
Copy link
Contributor

Resolves #1739

@davehewy davehewy requested a review from a team as a code owner November 30, 2021 16:05
@davehewy davehewy force-pushed the policy-check-code-dir-doc-update branch from fd0b748 to 5f81beb Compare November 30, 2021 16:09
@davehewy davehewy force-pushed the policy-check-code-dir-doc-update branch from 5f81beb to 89b2d84 Compare November 30, 2021 16:12
@chenrui333 chenrui333 changed the title Add clarity + further policy_check examples to docs fixes docs: add clarity and further policy_check examples Dec 4, 2021
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenrui333 chenrui333 merged commit 4370dc6 into runatlantis:master Dec 8, 2021
steps:
- init
- plan
policy_check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be a : here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot

owners:
users:
- example-dev
policy_sets:
Copy link
Contributor

@oysteingraendsen oysteingraendsen Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is indented one too much as it's not a part of the owners object?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I'll put a fix pr together for both.

- plan
policy_check
steps:
- policy_check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacks a :?

@davehewy
Copy link
Contributor Author

@oysteingraendsen apologies for the delay. fixed in #1945 👍

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
* Add clarity + further policy_check examples to docs

* Fix broken link to Atlantis on AWS Fargate Terraform module

Co-authored-by: Dave Heward <74298782+davidh-unmind@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conftest policy_sets "<CODE_DIRECTORY>" path clarification
4 participants