fix: allow requests to /healthz without authentication #1896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Basic Auth support was added in #1777, however this disabled the ability to use AWS ELB health checks against the
/healthz
endpoint. This purpose of this change is to allow the/healthz
endpoint to work for systems that check automatically and do not support authentication or it is desired to configure without authentication, including AWS ELB health checks and Kubernetes probes.Solution
This PR changes the behavior of the middleware when it checks if Basic Auth is enabled to allow unauthenticated requests to
/healthz
in the same way that requests to/events
were excepted from the check.