Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating client interface and adding ApprovalStatus model #1827

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Updating client interface and adding ApprovalStatus model #1827

merged 1 commit into from
Sep 22, 2021

Conversation

Aayyush
Copy link
Contributor

@Aayyush Aayyush commented Sep 22, 2021 •
edited
Loading

Changes:

  • Adding a new model: ApprovalStatus that encapsulates: isApproved, approvedBy, and dateOfApproval
  • Adding ApprovalStatus to ProjectCommandContext and CommandContext
  • Changing method signature for PullIsApproved to return ApprovalStatus instead of boolean.

@Aayyush Aayyush requested a review from a team as a code owner September 22, 2021 17:11
@nishkrishnan nishkrishnan merged commit bb2c239 into runatlantis:master Sep 22, 2021
@nishkrishnan nishkrishnan deleted the add-approval-metadata branch September 22, 2021 19:41
Aayyush referenced this pull request in lyft/atlantis Sep 22, 2021
@Aayyush
Pulling [#1827-Updating client interface and adding ApprovalStatus mo…
f19e019 
…del] from master
msarvar referenced this pull request in lyft/atlantis Sep 27, 2021
@Aayyush
Adding approval metadata to project command context [Pulling from ups…
b5018de 
…tream] (#116)

* Pulling [#1827-Updating client interface and adding ApprovalStatus model] from master

* Fix failing test
msarvar referenced this pull request in lyft/atlantis Sep 27, 2021
@Aayyush @msarvar
Adding approval metadata to project command context [Pulling from ups…
7375de8 
…tream] (#116)

* Pulling [#1827-Updating client interface and adding ApprovalStatus model] from master

* Fix failing test
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@Aayyush @krrrr38
Updating client interface and adding ApprovalStatus model (runatlanti…
786d8a3 
…s#1827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishkrishnan nishkrishnan nishkrishnan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aayyush @nishkrishnan