Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct cast from int to string in error message formatting #1327

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

acastle
Copy link
Contributor

@acastle acastle commented Dec 21, 2020

Small behavioral bug that has been around for a while. In the error message we are casting the index to a rune resulting in text characters rather than the numeric string.

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #1327 (367f9f0) into master (06991d7) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1327   +/-   ##
=======================================
  Coverage   70.05%   70.05%           
=======================================
  Files          74       74           
  Lines        5540     5540           
=======================================
  Hits         3881     3881           
  Misses       1303     1303           
  Partials      356      356           
Impacted Files Coverage Δ
server/events/db/boltdb.go 70.65% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06991d7...367f9f0. Read the comment docs.

@acastle acastle merged commit d827f2c into runatlantis:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant