Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs for custom embeddings #15929

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

logan-markewich
Copy link
Collaborator

With pydanticv2, the init call should always come before using self for anything

Fixes #15927
Fixes #15923

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 9, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@logan-markewich logan-markewich merged commit 51a3e4c into main Sep 9, 2024
10 checks passed
@logan-markewich logan-markewich deleted the logan/fix_custom_embedding_example branch September 9, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
1 participant