fix: handle empty response in Bedrock AnthropicProvider #14479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
sansmoraxz
changed the title
nerdai
reviewed
Jul 1, 2024
| @@ -147,7 +147,9 @@ def get_text_from_stream_response(self, response: dict) -> str: | |||
| return "" | |||
|
|
|||
| def get_text_from_response(self, response: dict) -> str: | |||
| return response["content"][0]["text"] | |||
| if response["content"]: | |||
There was a problem hiding this comment.
I guess it's an Optional type?
nit (if this also works): return response["content"][0]["text"] or ""
There was a problem hiding this comment.
No it does not. It was my earlier implementation, when testing privately.
the content array may be empty, and index of list 0 will give 'list index out of range'.
There was a problem hiding this comment.
Got it. Thanks for the reply.
nerdai
approved these changes
Jul 1, 2024
|
fyi @sansmoraxz have you tried the bedrock converse api yet? The implementation is much more simple, supports native function calling, and is likely less error prone |
|
Sure. Will give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add bounds check as response may be empty for bedrock anthropic api
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods