Enhance SlackReader to fetch Channel IDs from Channel Names/Patterns #14429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for channel name patterns (exact names and regex) in SlackReader. - Updated load_data method to handle both channel IDs and name patterns, combining results.
- Added support for channel name patterns (exact names and regex) in SlackReader. - get_channel_ids method to get channel ids from given channel names or regex patterns.
dosubot
bot
added
the
size:M
- Improved error handling - Added CHANGELOG - Updated version
- Update SlackDemo Notebook for example using get_channel_ids
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dosubot
bot
added
size:L
- Handle `not_in_channel` error by logging and exiting the loop to prevent indefinite retries. - Implement a default retry interval for rate limiting, ensuring controlled retries. - Enhances overall error handling and robustness.
|
@logan-markewich , please help with the review on this PR. |
logan-markewich
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
SlackReaderclass to support filtering Slack channels based on channel name patterns, including exact names and regular expressions. This update makes it easier to specify and retrieve conversations from channels by adding method to get channel IDs using channel names or regex pattern.Changes
Feature: Added support for extracting channel ids from channel name patterns (exact names and regex) in
SlackReader.Enhancement: Added the
get_channel_idsmethod to fetch channel ids from name patterns, these ids can be further used inload_datasame as before.Bug fixes
not_in_channelerror or any other error exceptratelimitedis returned by Slack, The code went into infinite loop of indefinite retries. Improved handling of the not_in_channel error. The reader now logs this error and breaks the loop, preventing indefinite retries.Motivation
The existing implementation required channel IDs to retrieve conversations, which could be cumbersome for users who may not have direct access to these IDs. By allowing the use of channel name patterns, this update simplifies the process of specifying channels, especially when dealing with multiple or dynamically named channels.
Testing
load_datamethod with various combinations of channel IDs and name patterns to confirm correct functionality.Please review the changes and provide feedback. Thank you!