Sync to hollie:master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user installs a local Perl version to run MisterHouse under instead of using the system-provided Perl, then the hardcoded Perl path at the shebang in get_email causes the module search path to be incorrect. /usr/bin/env perl properly solves this issue.
new file: AD2USB.pm
modified: AD2USB.pm
- Allows for use of all Generic_Item options including tie_events - Remove states because this is not an "editable" object
Tabs are set at 3 spaces which is odd
Why are we hardcoding $Self?
Can't use a global variable, otherwise users would not be able to have multiple panels setup in MH. Greatly simply DefineCmdMsg mess.
Make new() sub much easier to read, get rid of verbose coding. Remove all changes to Config Hash, this should be read-only as it represents the contents of the ini file, this contents can be updated by MH
No need for this if regex includes start and end of line
No need for this
Also cleanup parser to make a little easier
…CheckCmd, Removed Switch Package Returning a hash makes the code infinitely more readable, no longer need to remember the numbers for various message types. Removed Switch to make compatible with Perl 5.8.8
Relying on substr is dangerous, particularly since a user can enable the !KPM: prefix. Add more message parsing to GetStatusType, this routine can likely be converted to parse_message and save a lot of code
Get rid of all of the complicated tests. Allow ChangeZones to loop around from a high zone to a low zone. NOTE: May need to add a check to ChangeZones to see if it is reseting a mapped zone.
Anytime we get a keypad message we can check the status bits. Stop using substr and use hash flags.
Wow, can't believe I missed that.
Using hash keys makes the code much more condensed and easier to read.
I have to admit I don't really understand all of the optional settings for wireless objects
This will prevent the write action from blocking if there is a delay connecting to the Nest server. The write process is a little complicated but should be very robust, it can handle queuing multiple write commands at once. Added a simple check of the write response, will now print an error message if the response is not OK. Fixes krkeegan#27 Fixes krkeegan#26
- Added a nifty debug routine that unifies the creation of uniform print_log messages Fixes krkeegan#25
Add Support for Nest Devices
Fix Link Generation in Items and Modules Documenation Pages
Much of it was simply copied from the INI section in the Insteon POD documentation Closes #448
Insteon: Add INI Documenation to mh.ini
Insteon/X10: Skip Calling Set_Receive on PLM
Updates mhl to treat exit code 99 as a normal restart
Ubuntu Fixes for Google TTS Support
Add ncid server support
Insteon: Add User Option to Enable PLM Restart; Prevent Crashes
Original commit message is below. 194cf56 X10/Insteon: Remove Line Which Attempted to Add the X10 Device to the PLM Symptoms: the PLM states parameter contained the entire hashes of any X10 devices. This made get_states useless on the PLM (it should return an empty array). Instead it returned a bunch of garbage. This further lead to crashed in the json and xml servers. Cause: the $interface->add($X10_Object) command was calling the add subroutine in Device_Item. I am not even sure how the inheritance allowed this to happen. But this routine expected a list of states to be passed as the first parameter not an object. Solution: Remove the offending call to add. It is not clear why this was used (the commit notes demonstrate that this was added when support for X10 over Insteon was added). Perhaps the drafter intended to add the X10 device as a member of the PLM? However, the PLM itself has no members, PLM scenes are allowed to have members. Alternatively, perhaps the drafter intended to add the object to the list maintained by InsteonManager? Adding some code to the X10_Item would allow this to work in theory, however it isn't clear to me why you would want this. The list is maintained so that the insteon_manager can assist in link management, something not done by X10 devices. We have also been operating without adding the X10 items to the object list for quite some time without incident. Indeed no current calls to find_members would even return an X10 device as they all specifiy Insteon packages. Finally, perhaps this is some vestige of the old Insteon code. Removing the offending line solves the issue, and does not appear to have any adverse effects.
X10/Insteon: Cherry-Pick Former Commit That was Erroneously Reverted
Fix bug as reported by jduda on the mailing list.
Insteon: Fix Error In Set Receive Affecting Presence Monitor Items
rudybrian
pushed a commit
that referenced
this pull request
Dec 17, 2016
Socket_Item print _log clean up
rudybrian
pushed a commit
that referenced
this pull request
Jul 28, 2020
rudybrian
pushed a commit
that referenced
this pull request
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.