Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #525 #526

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Fixes issue #525 #526

merged 3 commits into from
Feb 2, 2022

Conversation

jasonfb
Copy link
Contributor

@jasonfb jasonfb commented Jan 31, 2022

fix for #525

mathieujobin
mathieujobin approved these changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch
Thank you for this

@mathieujobin mathieujobin merged commit 3572129 into rubysherpas:core Feb 2, 2022
@mathieujobin mathieujobin mentioned this pull request Feb 2, 2022
Closed
karunkumar1ly pushed a commit to edcast/paranoia that referenced this pull request Feb 6, 2024
@jasonfb @arun-zc
Do not include tests files in packaged gem (rubysherpas#526)
3eaff75 
* changing location of rspec file

* trying a graceful fail here

* wrapping in rails env check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieujobin mathieujobin mathieujobin approved these changes

Assignees
No one assigned
Labels
v2.5.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonfb @mathieujobin